Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against php 8.1 #910

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Test against php 8.1 #910

merged 2 commits into from
Nov 30, 2021

Conversation

sergiy-petrov
Copy link
Contributor

No description provided.

@jrfnl
Copy link
Contributor

jrfnl commented Oct 28, 2021

Please see PR #915 - the build would currently NOT pass on PHP 8.1. This was "invisible" due to incorrect configuration, but that does not mean that the package is compatible with PHP 8.1 without further changes. Please see PRs #919 and #920 for the changes which are needed.

@sergiy-petrov
Copy link
Contributor Author

Hi @jrfnl
Wow I didn't know that error_reporting is default to E_ALL & ~E_DEPRECATED & ~E_STRICT in SetupPHP actions. Thanks for the info.

I think my PR can be merged later, when #915, #919 and #920 are merged in?

@jrfnl
Copy link
Contributor

jrfnl commented Oct 28, 2021

Hi @jrfnl Wow I didn't know that error_reporting is default to E_ALL & ~E_DEPRECATED & ~E_STRICT in SetupPHP actions. Thanks for the info.

Yes, was an unpleasant discovery when I found that out myself ;-) Resulted in lots of lots of PRs to fix this in the actions workflows of various repos.

I think my PR can be merged later, when #915, #919 and #920 are merged in?

Correct, but those do need to be merged first.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #910 (44e0933) into master (3a66916) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #910   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       180       180           
===========================================
  Files             20        20           
  Lines            464       464           
===========================================
  Hits             464       464           

@ramsey
Copy link
Contributor

ramsey commented Nov 30, 2021

Thank you!

@ramsey ramsey merged commit 7580630 into thephpleague:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants