Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command to generate public and private keys #106

Open
fbourigault opened this issue Oct 13, 2022 · 1 comment
Open

Command to generate public and private keys #106

fbourigault opened this issue Oct 13, 2022 · 1 comment

Comments

@fbourigault
Copy link
Contributor

It would really improve DX like it was done for LexikJWTAuthenticationBundle.

Is it possible to copy the command from https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/Command/GenerateKeyPairCommand.php ?

I would say yes, but as I'm not an OSS licenses expert, I would like some advice on this topic.
@chalasr
Copy link
Member

chalasr commented Oct 16, 2022

In general, that would require including the upstream bundle's licence as a comment on top of the copied file.
But, since that bundle is maintained by me as well, we can skip that requirement :) PR welcome!

@fbourigault fbourigault mentioned this issue Oct 20, 2022
Merged
2 tasks
chalasr added a commit that referenced this issue Apr 9, 2024
@chalasr
feature #108 Generate keys commands (fbourigault)
58d4b11 
This PR was squashed before being merged into the 0.4-dev branch.

Discussion
----------

Generate keys commands

Here is my proposal to implement #106.

The first commit is an import of the command and the test from `LexikJWTAuthenticationBundle` to make review of change easier.

# To do

- [x] Make `$algorithm` a command option as `LeagueOAuth2ServerBundle` doesn't have such configuration option.
- [x] Register the command as a service.

Commits
-------

79141d2 Generate keys commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fbourigault @chalasr