Added User Credentials and Refresh Token Grants #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so it is inline with the spec, but added expires for the old usage of expires_in. Made redirect_uri in oauth_sessions ALLOW NULL since user_credential grants don't have a redirect
| throw new \Oauth2\Authentication\ClientException($this->errors['invalid_credentials'], 0); | ||
| } | ||
|
|
||
| else |
There was a problem hiding this comment.
The else could be removed.
|
FYI I've fixed all the unnecessary if/else blocks that @FrenkyNet commented on in my refactor |
|
So I've cherry-picked some of what you've committed and done a ton of refactoring and now there is a new
Once I've finished this work and added some more unit tests I will add some more code so that adhoc grants can be registered. |
datapp
pushed a commit
to datapp/oauth2-server
that referenced
this pull request
Jul 3, 2019
sathishcel
pushed a commit
to CelestialSystem/oauth2-server-fork
that referenced
this pull request
Apr 20, 2020
TR-349 adding xml extension check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the user_credentials and refresh_token grants. Fixed expires_in so it is inline with the spec, but added expires for the old usage of expires_in. Made redirect_uri in oauth_sessions ALLOW NULL since user_credential grants don't have a redirect.