Add interfaces for incoming notifications #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of adding interfaces here, but can't merge a failing build. |
| /** | ||
| * Was the transaction successful? | ||
| * | ||
| * @return string Transaction status, one of {@see STATUS_COMPLETED}, {@see #STATUS_PENDING}, or {@see #STATUS_FAILED}. |
There was a problem hiding this comment.
This line is failing the codestyle checks. It's too long.
|
All checks pass now. |
|
can someone merge it? i would love to base my next changes on the checkout.com gateway on it :) |
greydnls
added a commit
that referenced
this pull request
Oct 27, 2015
Add interfaces for incoming notifications
|
👍 Thank you @sergej-koscejev ! |
|
thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion pull request to thephpleague/omnipay#215.