V2 omnipay mollie #49
Conversation
…me doc blocks -- second bunch
composer.json
Outdated
| "require": { | ||
| "omnipay/common": "^3" | ||
| }, | ||
| "require-dev": { | ||
| "omnipay/tests": "^3", | ||
| "squizlabs/php_codesniffer": "^3", | ||
| "phpro/grumphp": "^0.14" | ||
| "phpro/grumphp": "^0.14", | ||
| "phpmd/phpmd": "@stable", |
There was a problem hiding this comment.
Can you provide versions for this? Or is there a specific reason to not require a version?
composer.json
Outdated
| @@ -29,13 +29,19 @@ | |||
| "autoload": { | |||
| "psr-4": { "Omnipay\\Mollie\\" : "src/" } | |||
| }, | |||
| "autoload-dev": { | |||
| "psr-4": { "Omnipay\\Mollie\\Test\\": "tests/" } | |||
| }, | |||
| "require": { | |||
| "omnipay/common": "^3" | |||
| }, | |||
| "require-dev": { | |||
| "omnipay/tests": "^3", | |||
There was a problem hiding this comment.
Can you bump this to ^3.1, that should fix the lowest dependencies. (I've updated the php-mock-client dependency in 3.1)
composer.json
Outdated
| "phpro/grumphp": "^0.14", | ||
| "phpmd/phpmd": "@stable", | ||
| "overtrue/phplint": "@stable", | ||
| "jakub-onderka/php-parallel-lint": "@stable" | ||
| }, | ||
| "extra": { | ||
| "branch-alias": { |
There was a problem hiding this comment.
Can you bump the branch-alias to 5.0.x-dev? Because of breaking changes etc.
src/Gateway.php
Outdated
| @@ -48,82 +69,82 @@ public function setApiKey($value) | |||
|
|
|||
| /** | |||
| * @param array $parameters | |||
| * @return \Omnipay\Mollie\Message\FetchIssuersRequest | |||
| * @return AbstractRequest|FetchIssuersRequest | |||
There was a problem hiding this comment.
Isn't it redundant to add AbstractRequest as the FetchIssuersRequest already extends that? (Same for the others below)
|
Thanks! Looks great, just a few nitpicks and it's good to merge :) |
|
Sorry, I meant |
composer.json
Outdated
| "jakub-onderka/php-parallel-lint": "@stable" | ||
| "phpmd/phpmd": "^2", | ||
| "overtrue/phplint": "^1", | ||
| "jakub-onderka/php-parallel-lint": "^0" |
There was a problem hiding this comment.
There is a 1.x release out: https://packagist.org/packages/jakub-onderka/php-parallel-lint
|
@barryvdh could you please have a look at the pipeline? |
|
Not really sure why he is complaining about not being able to install 3.0.1 |
|
Yay! It works! |
|
Cool, so this is ready to merge? |
|
This is tagged as 5.0.0 now |
|
@willemstuursma Thanks :). This helps a lot! |
|
Np @roelvanduijnhoven. Contact me at willem@mollie.com if you need technical support and I'll get you in touch with the right people. |
No description provided.