New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatible override of `getRedirectData()` in `FetchTransactionResponse` #90

Open

nfourtythree wants to merge 2 commits into thephpleague:master from nfourtythree:master

nfourtythree commented Jun 23, 2023

Currently FetchTransactionResponse is redeclaring the getRedirectData() method and always returning null.

This return type does not match the documented and implemented return in Omnipay Common's AbstractResponse

See here: https://github.com/thephpleague/omnipay-common/blob/master/src/Common/Message/AbstractResponse.php#L179-L187

This PR fixes the issue by removing the redeclaration of the method in the class as the inherited implementation does everything that is required.

nfourtythree added 2 commits

June 23, 2023 15:33


          Fix incompatible override of getRedirectData() in `FetchTransaction…

8fe14f6

…Response`


          Fix typo

b7169c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet