Compatibility with omnipay-common:^3.0 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix incorrect response class being generated (causes card declines to be accepted) * Fix purchase response message to actually have failure reason if available (instead of an error from no 'message') * Add more docblocks * Add proper abstract function definition for getEndpoint * Abstract JsonAuthorizeResponse to reduce duplication * Update unit test coverage, including distinction between failure, error and malformed cases * Add JSON gateway to README
|
@KirbyFox don't think so, haven't change any business logic, just compatibility with latest omnipay |
|
@KirbyFox Not sure how to do that with Sylius, but since I am doing it similar as they do it: I am having these two fields inside my Payment Configuration Form: ->add('factory', TextType::class, [
'data' => 'omnipay',
'empty_data' => 'omnipay'
])
->add('type', TextType::class, [
'data' => 'WorldPay\\Json',
'empty_data' => 'WorldPay\\Json'
])This basically sets the config factory to omnipay with type WorldPay\Json. The rest is done by OmnipayBridge. |
18 tasks
|
@amacneil any thoughts on this? |
|
ping @barryvdh |
|
yeah :) 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes WorldPay compatible with the latest Omnipay Alpha and merges also PR #26 (makes total sense to me, so I merged it here as well, if you wanna see only changes for the newest version, have a look at 87a2d03)
This is necessary to make omnipay-worldpay compatible with symfony-stack 3.*.