Updated Silex to ~2.0. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @carl-boisvert thanks for the contribution. I'm not familiar with Silex 2.0 myself so I can technically verify this, but if this patch works for your app then that should be fine. One thing I noticed was the tests now fail due to old PHP version requirements. I've updated master to test against the currently supported versions, could you please rebase your branch against that so the tests run? Thanks |
marcqualie
reviewed
Jul 17, 2017
| @@ -18,10 +19,9 @@ class StatsdServiceProvider implements ServiceProviderInterface | |||
| * Register Service Provider | |||
| * @param Application $app Silex application instance | |||
There was a problem hiding this comment.
The variable type has now changed, could you please also update the documentation here
The ServiceProviderInterface has change namespace in version ~2.0. It's now: use Pimple\ServiceProviderInterface; Updated the StatsdServiceProvider to reflect that change
carl-boisvert
force-pushed
the
Update-Silex-Version
branch
from
13eea1a to
9d9f893
Compare
|
Here we go, rebase done and doc updated! Thanks for the feedback! |
|
Thanks @carl-boisvert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silex 2 has been release last year and there was some changes that this library doesn't support.
I don't know if there's a particular reason as why it wasn't updated, but I'm proposing this pull request to update the Silex version to ~2.0.
The ServiceProviderInterface has change namespace in version ~2.0. It's now:
use Pimple\ServiceProviderInterface;
Updated the StatsdServiceProvider to reflect that change