Propagate ConnectionException message via trigger_error() #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it presently stands, the `ConnectionException` is thrown when opening a socket fails and contains the system-level error code and message. This information, however, is only accessible if the `throwConnectionExceptions` flag is set and the original exception is propagated to the consumer. If the exception is disabled, then a user warning will be created using the `trigger_error()` function, which unfortunately does not carry an information from the exception, leading to inability to properly debug connection issues. With this change the original exception message will be appended to the produced warning.
filakhtov
commented
Jun 10, 2020
| @@ -40,7 +40,7 @@ function ($errno, $errstr, $errfile, $errline, $errcontext) use ($testCase, &$ha | |||
| $handlerInvoked = true; | |||
|
|
|||
| $testCase->assertSame(E_USER_WARNING, $errno); | |||
| $testCase->assertSame( | |||
| $testCase->assertContains( | |||
There was a problem hiding this comment.
Note: I am deliberately doing a substring match here, because the code and the message might differ per platform or the standard library in use.
filakhtov
changed the title
|
It would be nice to have this added @marcqualie 🙏 🙇 |
colinodell
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why?
As it presently stands, the
ConnectionExceptionis thrown when opening a socket fails and contains the system-level error code and message. This information, however, is only accessible if thethrowConnectionExceptionsflag is set and the original exception is propagated to the consumer. If the exception is disabled, then a user warning will be created using thetrigger_error()function, which unfortunately does not carry an information from the exception, leading to inability to properly debug connection issues. With this change the original exception message will be appended to the produced warning.Before
After