Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block on invalid token #258

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Do not block on invalid token #258

merged 1 commit into from
Nov 21, 2021

Conversation

thepieterdc
Copy link
Owner

@thepieterdc thepieterdc commented Nov 21, 2021

This PR fixes error handling for invalid/missing tokens by making the error message non-blocking.

Fixes #256

@thepieterdc thepieterdc added the bug 🐛 Something isn't working label Nov 21, 2021
@thepieterdc thepieterdc requested a review from stijndcl November 21, 2021 12:39
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #258 (b6f9a7f) into master (a89f8ea) will decrease coverage by 0.18%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   47.73%   47.55%   -0.19%     
==========================================
  Files          34       34              
  Lines         553      553              
  Branches       93       94       +1     
==========================================
- Hits          264      263       -1     
  Misses        274      274              
- Partials       15       16       +1     
Flag Coverage Δ
integration 47.19% <23.52%> (-0.19%) ⬇️
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/api/client.ts 74.41% <0.00%> (ø)
src/treeView/dataProvider.ts 20.00% <12.50%> (ø)
src/extension.ts 78.78% <75.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89f8ea...b6f9a7f. Read the comment docs.

@thepieterdc thepieterdc merged commit 359fd49 into master Nov 21, 2021
@thepieterdc thepieterdc deleted the fix/listen-to-settings branch November 21, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Authentication fails
2 participants