Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UX for RequestError #375

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Conversation

BTWS2
Copy link
Contributor

@BTWS2 BTWS2 commented Mar 14, 2022

This approach guides the users to the solution, without leaving VS Code:

  1. Shows the error and shows the solution with a button. Don't solve automatically because user needs to know a setting will change to solve the error.
    Fix_error
  2. Setting is shown to user. The blue bar shows the setting has changed.
  3. Info message tells user the setting changed. Refresh treeview to show everything works now.
    image

Closes #363.

@BTWS2 BTWS2 requested a review from thepieterdc as a code owner March 14, 2022 22:29
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #375 (149600d) into master (9a93f4c) will decrease coverage by 0.57%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   53.21%   52.64%   -0.58%     
==========================================
  Files          34       34              
  Lines         560      568       +8     
  Branches       96       98       +2     
==========================================
+ Hits          298      299       +1     
- Misses        231      238       +7     
  Partials       31       31              
Flag Coverage Δ
integration 52.11% <27.27%> (-0.57%) ⬇️
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/api/client.ts 62.74% <20.00%> (-9.99%) ⬇️
src/constants/actions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a93f4c...149600d. Read the comment docs.

Copy link
Owner

@thepieterdc thepieterdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will modify this PR tomorrow to execute this logic in the error handler; so that the user does not have to deal with this themselves.

@thepieterdc thepieterdc linked an issue Mar 14, 2022 that may be closed by this pull request
@thepieterdc thepieterdc merged commit 1b4119b into thepieterdc:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants