Fix the folder-opening dialog #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 52.28% // Head: 51.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 52.28% 51.73% -0.56%
==========================================
Files 34 34
Lines 568 576 +8
Branches 99 100 +1
==========================================
+ Hits 297 298 +1
- Misses 238 246 +8
+ Partials 33 32 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
thepieterdc
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no folder is opened, the wrong function was used. This resulted in the pop-up not appearing.
The fix proposed in this PR first tells users that they have to pick a folder, and adds a button to allow students to choose a folder.
For ease-of-mind, selecting files & multiple folders are disabled. Just choose a folder.
Note: this doesn't show the documents anymore after opening the folder, as
windowandworkspacedon't really exist anymore (choosing a folder re-creates these). The file is still created. Students can just click on the exercise again afterwards.