-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial version of credentials manager #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If running on K8s node (determined by presence of account token at `/var/run/secrets/kubernetes.io/serviceaccount/token`), then try to fetch AWS credentials from Vault. Otherwise fallback to default AWS session that can load credentials from environment.
I'm pushing it now so I can try converting some client apps to use it. |
The data comes from the local k8s configuration, and is not shareable
bodhi
force-pushed
the
vault-aws-credentials
branch
from
December 12, 2018 01:37
7059362
to
d698f58
Compare
Conflicts: CHANGELOG.md README.md
Conflicts: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype to have a single entry point for apps to use to manage credentials.
At the moment it supports:
AWS_SDK_LOAD_CONFIG
andAWS_PROFILE
.2: AWS: authenticating using K8s service accounts against Vault.
I have a test app that can use either service with no code changes (only environment variables), it's coming soon. Also tests and documentation...