Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source InfluxDB credentials via Vault #39

Merged
merged 6 commits into from
Sep 2, 2019
Merged

Conversation

bodhi
Copy link
Member

@bodhi bodhi commented Aug 28, 2019

No description provided.

@bodhi bodhi self-assigned this Aug 28, 2019
…ires

1. Add signalling system to Vault client to notify
   on (re-)authentication.

2. Allow passing a custom InfluxDB client to the appkit monitoring
   system.

3. Create a proxy InfluxDB client that can dynamically change the
   wrapped client.

4. When Vault authenticates, fetch new InfluxDB credentials, and
   configure a new InfluxDB client with those credentials.
@bodhi bodhi force-pushed the vault-influxdb-creds branch from 8305d33 to 9c26b2a Compare August 28, 2019 05:54
@bodhi
Copy link
Member Author

bodhi commented Aug 28, 2019

The build failed on Semaphore

# github.com/hashicorp/vault/vendor/github.com/hashicorp/go-retryablehttp
../../hashicorp/vault/vendor/github.com/hashicorp/go-retryablehttp/client.go:447:17: c.HTTPClient.CloseIdleConnections undefined (type *http.Client has no field or method CloseIdleConnections)
...

hashicorp/go-retryablehttp made a change that is not compatible with Go v1.11, but Semaphore doesn't support Go v1.12 yet 😭.

@idealhack
Copy link
Contributor

Semaphore doesn't support Go v1.12 yet 😭

I know which project to on-board on prow next now :trollface:

@bodhi
Copy link
Member Author

bodhi commented Aug 28, 2019

I think I can use modules to lock the tests to an earlier version that works on v1.11...

@bodhi bodhi force-pushed the vault-influxdb-creds branch from 3d2b9b1 to b180f6e Compare September 2, 2019 01:59
@bodhi
Copy link
Member Author

bodhi commented Sep 2, 2019

I'm not going to fix the failing build in this PR.

@bodhi bodhi merged commit 67cf885 into master Sep 2, 2019
@bodhi bodhi deleted the vault-influxdb-creds branch September 3, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants