-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customize deployment strategy type #50
base: master
Are you sure you want to change the base?
Conversation
Test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the withoutRollingUpdate
param is too specific (i.e: what if there are new strategy in the future?)
I suggest that we use a plain string param stategy
with acceptable values: ['RollingUpdate', 'Recreate'].
Also we need to add validations to make sure strategy = 'Recreate'
is not used along with the maxSurge
param.
Support disable rolling update (
.spec.strategy.type
can beRecreate
).spec.strategy.type
=RollingUpdate
withoutRollingUpdate
=true
Ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy