Skip to content
This repository has been archived by the owner on Aug 6, 2021. It is now read-only.

Update scripts #3

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Update scripts #3

merged 2 commits into from
Oct 8, 2020

Conversation

thepwagner
Copy link
Owner

Continues the shiny new updater.Group from #2 .

  • rename frequency to cooldown, which I think is closer to how I think it will be implemented (group.lastPR.age < cooldown
  • introduce pre-script and post-script hooks, to be executed after every update group.

post-script is 💯 for code generation: I'm planning to use it to regenerate after the pattern: /.*protoc-.*/group is updated.

I have no idea what you'd use pre-script for, but ☯️ .

This is still vaporware, but with a new name.

I think it's more clear: check whenever, but if a PR was opened more
than this ago I don't want to see it.
I want this for code generation, like regenerating protobufs when
`protoc` is updated.
@thepwagner
Copy link
Owner Author

Works for me:

          groups: |
            - name: buf
              pattern: github.com/bufbuild/buf
              post-script: script/protoc

Screen Shot 2020-10-08 at 4 31 02 PM

@thepwagner thepwagner merged commit 6ff699c into main Oct 8, 2020
@thepwagner thepwagner deleted the update-scripts branch October 8, 2020 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant