Add health check monitoring for EXL2 errors #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A status code of 503 makes more sense to use. Signed-off-by: kingbri <bdashore3@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your pull request related to a problem? Please describe.
Recently when hibernating my PC I experienced the model unloading and tabbyAPI getting itself stuck reloading the EXL2 container every request.
Why should this feature be added?
This issue adds an internal logging system for fatal errors and code to auto generate a response for the health check endpoint so that it is possible to automatically restart the program if this happens again and fix the error
Examples
The health check endpoint returns 200 OK and status healthy on my machine even when every request is responded to with an error. This would fix that.
Additional context
In the future it will be possible to expand this system easily if more possible fatal errors are discovered by adding a statement to register them in the health manager singleton.