Merge pull request ing-bank#1464 from varun-aggarwal/fix/max-date-error

fix(validate-messages): correct description of MaxNumber, MinNumber, …
thescientist13 · Aug 18, 2021 · c1397d8 · c1397d8
2 parents 97c24d2 + 8a50e17
commit c1397d8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/.changeset/slimy-apes-teach.md b/.changeset/slimy-apes-teach.md
@@ -0,0 +1,5 @@
+---
+'@lion/validate-messages': patch
+---
+
+Fixed description of MaxNumber, MinNumber, MinDate and MaxDate validations
diff --git a/packages/validate-messages/translations/en.js b/packages/validate-messages/translations/en.js
@@ -8,12 +8,12 @@ export default {
       'Please enter a correct {fieldName} (between {params.min} and {params.max} characters).',
     Pattern: 'Please enter a valid {fieldName}',
     IsNumber: 'Please enter a valid {fieldName}.',
-    MinNumber: 'Please enter a(n) {fieldName} higher than {params}.',
-    MaxNumber: 'Please enter a(n) {fieldName} lower than {params}.',
+    MinNumber: 'Please enter a(n) {fieldName} higher than or equal to {params}.',
+    MaxNumber: 'Please enter a(n) {fieldName} lower than or equal to {params}.',
     MinMaxNumber: 'Please enter a(n) {fieldName} between {params.min} and {params.max}.',
     IsDate: 'Please enter a valid date (DD/MM/YYYY).',
-    MinDate: 'Please enter a(n) {fieldName} after {params, date, YYYYMMDD}.',
-    MaxDate: 'Please enter a(n) {fieldName} before {params, date, YYYYMMDD}.',
+    MinDate: 'Please enter a(n) {fieldName} after or equal to {params, date, YYYYMMDD}.',
+    MaxDate: 'Please enter a(n) {fieldName} before or equal to {params, date, YYYYMMDD}.',
     MinMaxDate:
       'Please enter a {fieldName} between {params.min, date, YYYYMMDD} and {params.max, date, YYYYMMDD}.',
     IsDateDisabled: 'This date is unavailable, please choose another one.',
@@ -27,12 +27,12 @@ export default {
     MinMaxLength:
       'Please enter a correct {fieldName} (between {params.min} and {params.max} characters).',
     IsNumber: 'Please enter a valid {fieldName}.',
-    MinNumber: 'Please enter a(n) {fieldName} higher than {params}.',
-    MaxNumber: 'Please enter a(n) {fieldName} lower than {params}.',
+    MinNumber: 'Please enter a(n) {fieldName} higher than or equal to {params}.',
+    MaxNumber: 'Please enter a(n) {fieldName} lower than or equal to {params}.',
     MinMaxNumber: 'Please enter a(n) {fieldName} between {params.min} and {params.max}.',
     IsDate: 'lease enter a valid date (DD/MM/YYYY).',
-    MinDate: 'Please enter a(n) {fieldName} after {params, date, YYYYMMDD}.',
-    MaxDate: 'Please enter a(n) {fieldName} before {params, date, YYYYMMDD}.',
+    MinDate: 'Please enter a(n) {fieldName} after or equal to {params, date, YYYYMMDD}.',
+    MaxDate: 'Please enter a(n) {fieldName} before or equal to {params, date, YYYYMMDD}.',
     MinMaxDate:
       'Please enter a {fieldName} between {params.min, date, YYYYMMDD} and {params.max, date, YYYYMMDD}.',
     IsDateDisabled: 'This date is unavailable, please choose another one.',