Fix: Remove TestDouble\ProphecyCreated

Fixes #18
theseer · Aug 15, 2020 · f66f52b · f66f52b
1 parent 7dc0dfe
commit f66f52b
Show file tree

Hide file tree

Showing 10 changed files with 2 additions and 124 deletions.
diff --git a/.psalm/baseline.xml b/.psalm/baseline.xml
@@ -66,8 +66,7 @@
     </PossiblyUnusedMethod>
   </file>
   <file src="src/Event/DispatchingEmitter.php">
-    <MissingThrowsDocblock occurrences="41">
-      <code>dispatch</code>
+    <MissingThrowsDocblock occurrences="40">
       <code>dispatch</code>
       <code>dispatch</code>
       <code>dispatch</code>
@@ -298,11 +297,6 @@
       <code>PartialMockCreatedSubscriber</code>
     </UnusedClass>
   </file>
-  <file src="src/Event/TestDouble/ProphecyCreatedSubscriber.php">
-    <UnusedClass occurrences="1">
-      <code>ProphecyCreatedSubscriber</code>
-    </UnusedClass>
-  </file>
   <file src="src/Event/TestDouble/TestProxyCreatedSubscriber.php">
     <UnusedClass occurrences="1">
       <code>TestProxyCreatedSubscriber</code>

diff --git a/src/Event/DispatchingEmitter.php b/src/Event/DispatchingEmitter.php
@@ -196,11 +196,6 @@ public function testDoublePartialMockCreated(): void
         $this->dispatcher->dispatch(new TestDouble\PartialMockCreated($this->telemetryInfo()));
     }
 
-    public function testDoubleProphecyCreated(): void
-    {
-        $this->dispatcher->dispatch(new TestDouble\ProphecyCreated($this->telemetryInfo()));
-    }
-
     public function testDoubleTestProxyCreated(): void
     {
         $this->dispatcher->dispatch(new TestDouble\TestProxyCreated($this->telemetryInfo()));

diff --git a/src/Event/Emitter.php b/src/Event/Emitter.php
@@ -71,8 +71,6 @@ public function testDoubleMockForTraitCreated(): void;
 
     public function testDoublePartialMockCreated(): void;
 
-    public function testDoubleProphecyCreated(): void;
-
     public function testDoubleTestProxyCreated(): void;
 
     public function testSuiteAfterClassFinished(): void;

diff --git a/src/Event/Registry.php b/src/Event/Registry.php
@@ -78,7 +78,6 @@ private static function registerDefaultTypes(): void
             TestDouble\MockCreated::class,
             TestDouble\MockForTraitCreated::class,
             TestDouble\PartialMockCreated::class,
-            TestDouble\ProphecyCreated::class,
             TestDouble\TestProxyCreated::class,
             Test\RunConfigured::class,
             Test\RunErrored::class,

diff --git a/src/Event/TestDouble/ProphecyCreated.php b/src/Event/TestDouble/ProphecyCreated.php
diff --git a/src/Event/TestDouble/ProphecyCreatedSubscriber.php b/src/Event/TestDouble/ProphecyCreatedSubscriber.php
diff --git a/src/Framework/TestCase.php b/src/Framework/TestCase.php
@@ -1962,11 +1962,7 @@ protected function prophesize(?string $classOrInterface = null): ObjectProphecy
             $this->recordDoubledType($classOrInterface);
         }
 
-        $prophecy = $this->getProphet()->prophesize($classOrInterface);
-
-        Event\Registry::emitter()->testDoubleProphecyCreated();
-
-        return $prophecy;
+        return $this->getProphet()->prophesize($classOrInterface);
     }
 
     /**

diff --git a/tests/_files/NullEmitter.php b/tests/_files/NullEmitter.php
@@ -129,10 +129,6 @@ public function testDoublePartialMockCreated(): void
     {
     }
 
-    public function testDoubleProphecyCreated(): void
-    {
-    }
-
     public function testDoubleTestProxyCreated(): void
     {
     }

diff --git a/tests/unit/Event/DispatchingEmitterTest.php b/tests/unit/Event/DispatchingEmitterTest.php
@@ -769,31 +769,6 @@ public function testTestDoublePartialMockCreatedDispatchesTestDoublePartialMockC
         $emitter->testDoublePartialMockCreated();
     }
 
-    public function testTestDoubleProphecyCreatedDispatchesTestDoubleProphecyCreatedEvent(): void
-    {
-        $subscriber = $this->createMock(TestDouble\ProphecyCreatedSubscriber::class);
-
-        $subscriber
-            ->expects($this->once())
-            ->method('notify')
-            ->with($this->isInstanceOf(TestDouble\ProphecyCreated::class));
-
-        $dispatcher = self::createDispatcherWithRegisteredSubscriber(
-            TestDouble\ProphecyCreatedSubscriber::class,
-            TestDouble\ProphecyCreated::class,
-            $subscriber
-        );
-
-        $telemetrySystem = self::createTelemetrySystem();
-
-        $emitter = new DispatchingEmitter(
-            $dispatcher,
-            $telemetrySystem
-        );
-
-        $emitter->testDoubleProphecyCreated();
-    }
-
     public function testTestDoubleTestProxyCreatedDispatchesTestDoubleTestProxyCreatedEvent(): void
     {
         $subscriber = $this->createMock(TestDouble\TestProxyCreatedSubscriber::class);

diff --git a/tests/unit/Event/TestDouble/ProphecyCreatedTest.php b/tests/unit/Event/TestDouble/ProphecyCreatedTest.php
-Original file line number
+Diff line change
@@ Expand Up / @@ -129,10 +129,6 @@ public function testDoublePartialMockCreated(): void @@
         {
         }
-        public function testDoubleProphecyCreated(): void
-        {
-        }
         public function testDoubleTestProxyCreated(): void
         {
         }
@@ Expand Down @@