Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer abstraction #569

Closed
wants to merge 24 commits into from
Closed

Timer abstraction #569

wants to merge 24 commits into from

Conversation

tsoutsman
Copy link
Member

@tsoutsman tsoutsman commented Jul 19, 2022 •
edited
Loading

This pull request abstracts hardware timers behind a generic ClockSource trait.

All existing functionality has been implemented, but there are a couple of additional features that can be addressed either in this PR, or a separate PR:

  • Supporting the APIC timer as a monotonic clock source
  • Supporting 32-bit HPETs
  • A source of randomness. Some of the network drivers were using HPET ticks as a seed for a PRNG which is obviously less than ideal. I replaced them with calls to for now _rdseed64_step but I'm not sure QEMU supports the instruction.
  • Natively calibrating the TSC. As I've written in a comment above the commented out native calibration code: "[Native calibration] does not work on QEMU. It returns a numerator, denominator, and hertz but they are wrong."
  • Supporting the RTC as a monotonic clock source? The code for RTC interrupts is there but I've commented it out for now.
  • Don't double initialise timers (once in register_early_sleeper and again in register_clock_source). This isn't currently an issue as running a source's init function twice happens to not cause problems but is something we should definitely fix.

@tsoutsman tsoutsman marked this pull request as ready for review July 19, 2022 03:08
tsoutsman added 24 commits July 19, 2022 17:43
@tsoutsman
Add timer abstraction
199b5da 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Implement timer abstraction for real-time clock
972fabd 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Add tests (and fix bugs) for RtcTimer Timer implementation.
19dc964 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Implement Timer for TscTimer
7ca8552 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Add Timer abstraction for HPET and TSC
cb10924 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Move RTC and TSC implementations to time crate
47466c3 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Move HPET implementation to time crate
b68f422 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Add interruput handling for HPET
c91194d 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Begin switch to time crate.
02a676f 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
(Mostly) finish the switch to time crate.
7fadd88 
There are still visible bugs.

Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Work on monotonic timer
f537322 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
More work on timer
ed370a9 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
More work
168c04e 
I've given up on commit messages because they just all blur together

Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Move RTC implementation into separate crate
e41dc5c 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Move TSC implementation to separate crate
7ace3d1 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Move PIT implementation into seperate crate
c20c402 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Move HPET implementation to a seperate crate
5fde017 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Add EarlySleeper trait
f52623a 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Return custom error enum when registering clocks
ab5fb5b 
The caller should be able to differentiate between the clock not
existing and an error occuring during initialisation.

Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Wrap/improve documentation
111a9c8 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Implement API changes
9898721 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Readd .gitignore
505d0db 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Minor fixups
5655c94 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Name change
ee9cbf6 
Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
@tsoutsman tsoutsman force-pushed the wip-timer-abstraction branch from fdc15ae to ee9cbf6 Compare July 19, 2022 07:47
@tsoutsman tsoutsman mentioned this pull request Jul 24, 2022
Closed
@kevinaboos kevinaboos marked this pull request as draft August 19, 2022 22:00
This was referenced Aug 20, 2022
Open
Merged
@tsoutsman tsoutsman closed this Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsoutsman