Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct zonky extractor #150

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: correct zonky extractor #150

merged 1 commit into from
Nov 12, 2024

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Nov 12, 2024

Addresses: #148

@github-actions github-actions bot added the fix Bug fix label Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

🐰 Bencher Report

Branchcorrect-zonky-extractor
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
extract📈 view plot
⚠️ NO THRESHOLD
203,030.00
lifecycle📈 view plot
⚠️ NO THRESHOLD
1,941,300,000.00
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.13%. Comparing base (b298e2b) to head (816c7c1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          76       76           
  Lines        9233     9233           
=======================================
  Hits         9153     9153           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 8f674e4 into main Nov 12, 2024
13 checks passed
@brianheineman brianheineman deleted the correct-zonky-extractor branch November 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant