Solidity v1.1.0 release #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains artifacts of contracts deployed on mainnet in v1.1.0 release. It also updates version in package.json.
✅ Deploy Preview for acre-dapp-testnet canceled.
|
✅ Deploy Preview for acre-dapp canceled.
|
r-czajkowski
approved these changes
Aug 29, 2024
pdyraga
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Confirmed the addresses against the upgrade transaction. Everything as expected.
r-czajkowski
added a commit
that referenced
this pull request
Sep 3, 2024
Depends on: #716 In this PR we introduce a couple of improvements to the MezoAllocator contract related to withdrawals from the Mezo Portal. ### Check if the withdrawal amount exceeds the deposit balance (1b95419) Here we improve the withdrawal function to check if the withdrawal amount exceeds the deposit balance. If the withdrawal amount exceeds the deposit balance, the function will revert with a custom error message. Before these changes, since the Portal contract changed the handling of partial and full withdrawals the withdrawal function reverted on `depositBalance -= uint96(amount);` with: ``` panic code 0x11 (Arithmetic operation overflowed outside of an unchecked block) ``` ### Include unallocated MezoAllocator balance in `withdraw` and `releaseDeposit` (1b9ba17, 0440580) In bb42bce we included the current balance of the MezoAllocator contract in the `totalAssets` function result. The balance can come from a rewards transfer or any donation. We haven't considered this balance in the `withdraw` function, which could lead to blocking the last user withdrawing the funds, as the balance of assets owned by them calculated based on `totalAssets` function, couldn't be fully withdraw due to unallocated balance being stuck in the `MezoAllocator` contract. In 1b9ba17 we introduce possibility to withdraw funds from the unallocated contract balance. For the `releaseDeposit` function we could face a problem when the Mezo Portal deposit is already released but some tokens were donated to the MezoAllocator contract, since the `Porta.withdraw` function would be reverting as there is no deposit, we won't be able to transfer the unallocated funds in the same call. We fixed it in 0440580. > [!IMPORTANT] > Please ignore failing integration tests, as these will be fixed in #718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains artifacts of contracts deployed on the mainnet in the v1.1.0 release. It also updates the version in package.json.
Important
Please ignore failing integration tests, as these will be fixed in #718