DApp integration with ledger live app #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the Ledger Live connector from the orangekit lib.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nkuba
added a commit
that referenced
this pull request
Nov 6, 2024
This is an integration PR that adds the necessary changes for the dapp to run on Ledger Live. Refs: #730 #742 #763 #759, #760, #797, #780, thesis/orangekit#143, thesis/orangekit#144 ### Important note Changes can only be tested in a Ledger Live app built from source. See the [Ledger Live repo](https://github.com/LedgerHQ/ledger-live), how to build from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the app with OrnageKit which delivers the provider for the Ledger Live App. The implementation of Ledger Live App support should not cause regression for previous solutions. The app should catch via the
embedparameter in the URL if it works under the Ledger Live App. If such a parameter is found, in the wgami configuration we should specify only one right connector.Testing