Add retry logic to HTTP calls in SDK #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed that the tBTC API calls are failing intermittently, which may be related to unstable Cloudflare workers infrastructure. This PR adds retry logic to the tBTC API calls to handle these failures. Requests to the tBTC API will be retried up to 5 times with an exponential backoff strategy.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Previously we were only retrying HTTP requests in the SDK for tBTC API calls. We can generalize this solution and apply it to all HTTP requests.
nkuba
changed the title
r-czajkowski
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed that the tBTC API calls are failing intermittently, which may be related to unstable Cloudflare workers infrastructure. This PR adds retry logic to the tBTC API calls to handle these failures. Requests to the tBTC API will be retried up to 5 times with an exponential backoff strategy.
Closes AENG-26