-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support for ES8336 on Intel Comet Lake #3248
Comments
I just bought Huawei Matebook d15 i3-10110U and can confirm the sound does not work (Dummy output shown as Output device). OS: Ubuntu 22.04 (development branch) Also tried the same kernel as @playXE linked https://github.com/himozzza/essx8336. After booting with it It displayed "Intel Corporation Comet Lake PCH-LP cAVS" as Output device and it correctly prompted me to select between "Headset" and "Headphones" when I plugged in headpone jack, but there was no sound neither on builtin speaker or headpones. This is my alsa-info: http://alsa-project.org/db/?f=95f73cdf9497ae38f36b4e12646d74826fbecdba Bluetooth audio works great. Thank you |
We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks for reporting this @Simonboot and @playXE . We are indeed missing quirks for this CML device. Can you retry with the branch https://github.com/plbossart/sound/tree/fix/es8336-codec You should boot the DSP and reach the point where a topology file is missing. You will have to try each of the files in this zip Please try with sof-cml-es8336-0.tplg copied as /lib/firmware/intel/sof-tplg/sof-cml-es8336.tplg, then 1 and 2. We need this trial-and-error method to figure out where the codec is attached to (I2S/SSP interface 0 1 or 2). |
forgot to add @hli25 on this one, not sure if you can help with the SSP connection - which SSP should be used on CML-based devices? |
atm I am running Windows on my laptop, is there any way to load this kernel with USB drive? Maybe compile kernel on WSL and then move it to bootable USB? |
@plbossart I am trying to build kernel in WSL and it fails:
Looks like the problem is a slightly newer version of GLibc? |
I don't have a Windows device so can't help with WSL. It's possible to take an existing USB drive with e.g. Ubuntu and add a different kernel. I did it a couple of years ago with the help of @linuxium, see https://github.com/plbossart/UbuntuLiveUSB. No idea if this still works or not. You might have more luck with Cubic. |
I'll probably buy a larger SSD and will install Linux near Windows because it seems to be quite hard to build linux kernel in WSL... |
We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Hi, I still do not have the ability to dualboot, is there something I can help with using my machine? I see that there are some commits that mention ES8336 |
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: #3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: #3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: #3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
commit ae26c08 upstream. We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject/linux#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
commit ae26c08 upstream. We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject/linux#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
it's so bad we even have documentation of what the issues are https://thesofproject.github.io/latest/getting_started/intel_debug/suggestions.html#es8336-support |
Even with 5.19.. It doesn't work |
perfect. so I will continue with bluethoot headphones or speaker for a long time. |
Just bought a Huawei MateBook K14 (21), board id KLVD-WXX9-PCB-B4 Seems there is some kind of pin mismatch. |
Added recommended information in https://github.com/thesofproject/linux/wiki/ES8336-support closing for now, please re-open an issue if the recommended setup doesn't work for you. |
Different topology filenames may be required depending on which SSP is used, and whether or not digital mics are present. This patch adds a tplg_quirk_mask and in the case of the SOF driver adds the relevant configurations. This is a short-term solution to the ES8336 support issues. In a long-term solution, we would need an interface where the machine driver or platform driver have the ability to alter the topology hard-coded low-level hardware support, e.g. by substituting an interface for another, or disabling an interface that is not supported on a given skew. BugLink: thesofproject#3248 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Link: https://lore.kernel.org/r/20220308192610.392950-7-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject/linux#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject/linux#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
BugLink: https://bugs.launchpad.net/bugs/1953731 commit ae26c08 upstream. We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject/linux#3248 Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
EDIT for everyone. Tested on 6.0.9 and https://github.com/yangxiaohua2009/custom-kernel and I can confirm it works (I have gentoo but it works without problems). EDIT: After reboot it stopped working 😢 |
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject/linux#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject/linux#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject/linux#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
commit ae26c08e6c8071ba8febb0c7c0829da96c75248c upstream. We've added quirks for ESS8336 but missed CML, add quirks for both LP and H versions. BugLink: thesofproject/linux#3248 Fixes: 9d36ceab9415 ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject/linux#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the information that some designs rely on CometLake was not shared. BugLink: thesofproject/linux#3248 Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> (cherry picked from commit 8a6cc0d) BUG=b:218766331 TEST=Test sound cards are listed and audio playback works. Signed-off-by: Terry Cheong <htcheong@chromium.org> Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com> (cherry picked from commit 8a6cc0d) Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
#3248 (comment) |
I did, anyway I've moved to a desktop pc and I don't have the Huawei anymore so not a problem anymore |
Sorry to be a bit direct but : Can we expect the needed patch to be in Linux 6.2 ? |
On latest live fedora audio through speakers works, but is very low by default. Few adjustments in alsamixer partially fixes the problem. Mics don't seem to work though. |
@dattiluca You may want to update your ucm to make your mic work if you are using latest system like Ubuntu 22.10. See https://github.com/alsa-project/alsa-ucm-conf. Or you can use ucm file here for old systems. Backup you file in /usr/share/alsa/ucm2/ before you do any change. Manuelly change amixer is another way, sample alsainfo alsa-info-Headphone.zip |
I installed latest ubuntu (22.10) and latest kernel (6.1.9). I copied the ucms in the proper folder, but nothing works. No mic, no speakers. The system detects the sound card as the only one, but adjustments in alsamixer don't change anything. |
@dattiluca try to run these commands. Maybe your speaker is turned off. Consider testing with alsa, not pipewire amixer cset name='Headphone Switch' on
amixer cset name='Speaker Switch' on
amixer cset name='Headphone Playback Volume' 10,10
amixer cset name='Right Headphone Mixer Right DAC Switch' on
amixer cset name='Left Headphone Mixer Left DAC Switch' on
amixer cset name='DAC Playback Volume' 999,999
amixer cset name='Headphone Mixer Volume' 999,999 |
On kernel 6.5.0 headphones work, but speakers not. |
Microphone not Working on Huawei D15 2020 |
Still doesn't work both speakers and headphones on Teclast F5. kernel: 6.8.4
|
Everything works fine out of the box on huawei d14 (HUAWEI NBD-WXX9-PCB-B4) & latest kernel & latest alsa-ucm-conf #!/nix/store/r9h133c9m8f6jnlsqzwf89zg9w0w78s8-bash-5.2-p15/bin/bash
set -e
#!/usr/bin/env sh
# For "Pro Audio" profile
# amixer cset name='Headphone Switch' on
# amixer cset name='Speaker Switch' on
# amixer cset name='Headphone Playback Volume' 10,10
# amixer cset name='Right Headphone Mixer Right DAC Switch' on
# amixer cset name='Left Headphone Mixer Left DAC Switch' on
# amixer cset name='DAC Playback Volume' 999,999
# amixer cset name='Headphone Mixer Volume' 999,999
#
# amixer sset "Dmic0" 70
# amixer sset "Dmic1 2nd" 70
# For "Play and record HiFI quality Music" profile
# Enables Right and Left speakers
amixer cset name='Right Headphone Mixer Right DAC Switch' on
amixer cset name='Left Headphone Mixer Left DAC Switch' on You can change your sound profile in pavucontrol |
Moved from thesofproject/sof
Is your feature request related to a problem? Please describe.
Huawei laptops ship with an Everest ES8336 sound card that is not supported by sofproject.
Describe the solution you'd like
Adding support for it would be really awesome
Describe alternatives you've considered
I already tried this repo which seems to contain a kernel built with support for it but the audio clearly does not work: https://github.com/himozzza/essx8336
Additional context
Booting Linux and trying lsmod or dmsg shows only one valid HDMI sound output on the laptop and nothing more. Here's what I get from Device Manager on Windows:
The text was updated successfully, but these errors were encountered: