Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for ES8336 on Intel Comet Lake #3248

Closed
playXE opened this issue Oct 29, 2021 · 261 comments
Closed

[FEATURE] Support for ES8336 on Intel Comet Lake #3248

playXE opened this issue Oct 29, 2021 · 261 comments
Labels
CML Applies to Comet Lake platform codec ES8336 codec Codec HW or driver restriction Community end-user or distro-reported issues enhancement New feature or request

Comments

@playXE
Copy link

playXE commented Oct 29, 2021

Moved from thesofproject/sof

Is your feature request related to a problem? Please describe.
Huawei laptops ship with an Everest ES8336 sound card that is not supported by sofproject.
Describe the solution you'd like
Adding support for it would be really awesome
Describe alternatives you've considered
I already tried this repo which seems to contain a kernel built with support for it but the audio clearly does not work: https://github.com/himozzza/essx8336
Additional context
Booting Linux and trying lsmod or dmsg shows only one valid HDMI sound output on the laptop and nothing more. Here's what I get from Device Manager on Windows:

ACPI\VEN_ESSX&DEV_8336&SUBSYS_152D1262
ACPI\ESSX8336
*ESSX8336

@simas-b
Copy link

simas-b commented Oct 29, 2021

I just bought Huawei Matebook d15 i3-10110U and can confirm the sound does not work (Dummy output shown as Output device).

OS: Ubuntu 22.04 (development branch)
Kernel 5.15.0-051500rc7-generic

Also tried the same kernel as @playXE linked https://github.com/himozzza/essx8336. After booting with it It displayed "Intel Corporation Comet Lake PCH-LP cAVS" as Output device and it correctly prompted me to select between "Headset" and "Headphones" when I plugged in headpone jack, but there was no sound neither on builtin speaker or headpones.
I could not hear any sound with speaker-test utility.

This is my alsa-info: http://alsa-project.org/db/?f=95f73cdf9497ae38f36b4e12646d74826fbecdba

Bluetooth audio works great.

Thank you

@playXE playXE changed the title [FEATURE] Support for ES8336 on Huawei Matebook D14-15-16 with i5-10210u [FEATURE] Support for ES8336 on Intel Comet Lake Oct 31, 2021
plbossart added a commit to plbossart/sound that referenced this issue Nov 3, 2021
We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue Nov 3, 2021
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
Copy link
Member

Thanks for reporting this @Simonboot and @playXE . We are indeed missing quirks for this CML device.

Can you retry with the branch https://github.com/plbossart/sound/tree/fix/es8336-codec

You should boot the DSP and reach the point where a topology file is missing.

You will have to try each of the files in this zip
cml.tar.gz

Please try with sof-cml-es8336-0.tplg copied as /lib/firmware/intel/sof-tplg/sof-cml-es8336.tplg, then 1 and 2. We need this trial-and-error method to figure out where the codec is attached to (I2S/SSP interface 0 1 or 2).

@plbossart plbossart added codec Codec HW or driver restriction CML Applies to Comet Lake platform Community end-user or distro-reported issues labels Nov 3, 2021
@plbossart
Copy link
Member

forgot to add @hli25 on this one, not sure if you can help with the SSP connection - which SSP should be used on CML-based devices?

@playXE
Copy link
Author

playXE commented Nov 5, 2021

atm I am running Windows on my laptop, is there any way to load this kernel with USB drive? Maybe compile kernel on WSL and then move it to bootable USB?

@playXE
Copy link
Author

playXE commented Nov 5, 2021

@plbossart I am trying to build kernel in WSL and it fails:

➜  sound git:(fix/es8336-codec) make -j6
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  HOSTCC  scripts/conmakehash
  HOSTCC  scripts/sortextable
  CHK     scripts/mod/devicetable-offsets.h
  HOSTCC  scripts/selinux/genheaders/genheaders
  HOSTCC  scripts/selinux/mdp/mdp
In file included from scripts/selinux/mdp/mdp.c:49:
./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map.
  245 | #error New address family defined, please update secclass_map.
      |  ^~~~~
make[3]: *** [scripts/Makefile.host:102: scripts/selinux/mdp/mdp] Error 1
In file included from scripts/selinux/genheaders/genheaders.c:19:
./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map.
  245 | #error New address family defined, please update secclass_map.
      |  ^~~~~
make[2]: *** [scripts/Makefile.build:573: scripts/selinux/mdp] Error 2
make[2]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.host:102: scripts/selinux/genheaders/genheaders] Error 1
make[2]: *** [scripts/Makefile.build:573: scripts/selinux/genheaders] Error 2
make[1]: *** [scripts/Makefile.build:573: scripts/selinux] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:562: scripts] Error 2

Looks like the problem is a slightly newer version of GLibc?

@plbossart
Copy link
Member

atm I am running Windows on my laptop, is there any way to load this kernel with USB drive? Maybe compile kernel on WSL and then move it to bootable USB?

I don't have a Windows device so can't help with WSL.

It's possible to take an existing USB drive with e.g. Ubuntu and add a different kernel. I did it a couple of years ago with the help of @linuxium, see https://github.com/plbossart/UbuntuLiveUSB. No idea if this still works or not. You might have more luck with Cubic.

@playXE
Copy link
Author

playXE commented Nov 6, 2021

I'll probably buy a larger SSD and will install Linux near Windows because it seems to be quite hard to build linux kernel in WSL...

@mengdonglin mengdonglin added the enhancement New feature or request label Nov 15, 2021
plbossart added a commit to plbossart/sound that referenced this issue Nov 19, 2021
We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue Nov 19, 2021
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@playXE
Copy link
Author

playXE commented Nov 20, 2021

Hi, I still do not have the ability to dualboot, is there something I can help with using my machine? I see that there are some commits that mention ES8336

fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 22, 2021
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 22, 2021
We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
ranj063 pushed a commit that referenced this issue Nov 23, 2021
We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: #3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
ranj063 pushed a commit that referenced this issue Nov 23, 2021
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: #3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
tiwai pushed a commit to tiwai/sound that referenced this issue Nov 23, 2021
We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 25, 2021
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
kv2019i pushed a commit that referenced this issue Nov 29, 2021
We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: #3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
kv2019i pushed a commit that referenced this issue Nov 29, 2021
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: #3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
kv2019i pushed a commit to kv2019i/linux that referenced this issue Nov 29, 2021
We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
kv2019i pushed a commit to kv2019i/linux that referenced this issue Nov 29, 2021
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Dec 6, 2021
commit ae26c08 upstream.

We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject/linux#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Dec 6, 2021
commit ae26c08 upstream.

We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject/linux#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
@plbossart
Copy link
Member

it's so bad we even have documentation of what the issues are

https://thesofproject.github.io/latest/getting_started/intel_debug/suggestions.html#es8336-support

@Neo-29
Copy link

Neo-29 commented Jul 21, 2022

Even with 5.19.. It doesn't work

@Tonyd4nc3
Copy link

perfect. so I will continue with bluethoot headphones or speaker for a long time.

@kyconny
Copy link

kyconny commented Jul 24, 2022

Just bought a Huawei MateBook K14 (21), board id KLVD-WXX9-PCB-B4
Spent some time attempting to get this to work on latest RC linux
Fresh install and I have sound! Though unfortunately it appears to be coming out of both the speakers, and the headphone jack at the same time. The speaker is marked as (unavailable) in pulse, and alsamixer doesn't let me adjust its volume. Funnily enough I have two distinct headphone controls, which appear to increase the volume of both the speaker and the headphones at the same time.

Seems there is some kind of pin mismatch.

@plbossart
Copy link
Member

Added recommended information in https://github.com/thesofproject/linux/wiki/ES8336-support

closing for now, please re-open an issue if the recommended setup doesn't work for you.

mikhailnov pushed a commit to mikhailnov/linux-kernel-rosa that referenced this issue Sep 9, 2022
Different topology filenames may be required depending on which SSP is
used, and whether or not digital mics are present.

This patch adds a tplg_quirk_mask and in the case of the SOF driver
adds the relevant configurations.

This is a short-term solution to the ES8336 support issues.

In a long-term solution, we would need an interface where the machine
driver or platform driver have the ability to alter the topology
hard-coded low-level hardware support, e.g. by substituting an
interface for another, or disabling an interface that is not supported
on a given skew.

BugLink: thesofproject#3248
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20220308192610.392950-7-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sboyanex pushed a commit to dineshXadireddi/Backport-series that referenced this issue Oct 7, 2022
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject/linux#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
sboyanex pushed a commit to dineshXadireddi/Backport-series that referenced this issue Oct 7, 2022
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject/linux#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
nvidia-bfigg pushed a commit to NVIDIA-BaseOS-6/linux-nvidia-5.19 that referenced this issue Nov 15, 2022
BugLink: https://bugs.launchpad.net/bugs/1953731

commit ae26c08 upstream.

We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject/linux#3248
Fixes: 9d36cea ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
@ghost
Copy link

ghost commented Nov 21, 2022

EDIT for everyone. Tested on 6.0.9 and https://github.com/yangxiaohua2009/custom-kernel and I can confirm it works (I have gentoo but it works without problems).

EDIT: After reboot it stopped working 😢

sboyanex pushed a commit to dineshXadireddi/Backport-series that referenced this issue Nov 28, 2022
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject/linux#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
sboyanex pushed a commit to dineshXadireddi/Backport-series that referenced this issue Dec 12, 2022
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject/linux#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
dineshXadireddi pushed a commit to dineshXadireddi/Backport-series that referenced this issue Dec 27, 2022
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject/linux#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
Rohail33 pushed a commit to Rohail33/Realking_xiaomi_xaga that referenced this issue Dec 31, 2022
commit ae26c08e6c8071ba8febb0c7c0829da96c75248c upstream.

We've added quirks for ESS8336 but missed CML, add quirks for both LP
and H versions.

BugLink: thesofproject/linux#3248
Fixes: 9d36ceab9415 ("ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232254.23362-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
rutumberx pushed a commit to dineshXadireddi/Backport-series that referenced this issue Jan 5, 2023
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject/linux#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
Vamshigopal pushed a commit to Vamshigopal/linux that referenced this issue Jan 9, 2023
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
Vamshigopal pushed a commit to Vamshigopal/linux that referenced this issue Jan 16, 2023
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
rutumberx pushed a commit to dineshXadireddi/Backport-series that referenced this issue Jan 19, 2023
We have configurations for this codec on APL, GLK, JSL and TGL, somehow the
information that some designs rely on CometLake was not shared.

BugLink: thesofproject/linux#3248
Fixes: 790049f ("ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211122232356.23505-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 8a6cc0d)

BUG=b:218766331
TEST=Test sound cards are listed and audio playback works.

Signed-off-by: Terry Cheong <htcheong@chromium.org>
Signed-off-by: Madhulika Dolke <madhulika.dolke@intel.com>
(cherry picked from commit 8a6cc0d)
Change-Id: Ib4aa6ea2d75c0c2d843ffb438c221a94997bdcee
@tshipenchko
Copy link

#3248 (comment)
Did you resolved your issue?

@ghost
Copy link

ghost commented Jan 20, 2023

#3248 (comment) Did you resolved your issue?

I did, anyway I've moved to a desktop pc and I don't have the Huawei anymore so not a problem anymore

@freechelmi
Copy link

Sorry to be a bit direct but : Can we expect the needed patch to be in Linux 6.2 ?

@dattiluca
Copy link

On latest live fedora audio through speakers works, but is very low by default. Few adjustments in alsamixer partially fixes the problem. Mics don't seem to work though.

@yangxiaohua2009
Copy link

@dattiluca You may want to update your ucm to make your mic work if you are using latest system like Ubuntu 22.10. See https://github.com/alsa-project/alsa-ucm-conf. Or you can use ucm file here for old systems. Backup you file in /usr/share/alsa/ucm2/ before you do any change.

Manuelly change amixer is another way, sample alsainfo alsa-info-Headphone.zip

@dattiluca
Copy link

@dattiluca You may want to update your ucm to make your mic work if you are using latest system like Ubuntu 22.10. See https://github.com/alsa-project/alsa-ucm-conf. Or you can use ucm file here for old systems. Backup you file in /usr/share/alsa/ucm2/ before you do any change.

Manuelly change amixer is another way, sample alsainfo alsa-info-Headphone.zip

I installed latest ubuntu (22.10) and latest kernel (6.1.9). I copied the ucms in the proper folder, but nothing works. No mic, no speakers. The system detects the sound card as the only one, but adjustments in alsamixer don't change anything.

@tshipenchko
Copy link

@dattiluca try to run these commands. Maybe your speaker is turned off. Consider testing with alsa, not pipewire

amixer cset name='Headphone Switch' on
amixer cset name='Speaker Switch' on
amixer cset name='Headphone Playback Volume' 10,10
amixer cset name='Right Headphone Mixer Right DAC Switch' on
amixer cset name='Left Headphone Mixer Left DAC Switch' on
amixer cset name='DAC Playback Volume' 999,999
amixer cset name='Headphone Mixer Volume' 999,999

@Mornongsmokie
Copy link

Mornongsmokie commented Dec 12, 2023

On kernel 6.5.0 headphones work, but speakers not.

@ochi12
Copy link

ochi12 commented Apr 9, 2024

Microphone not Working on Huawei D15 2020

@katyo
Copy link

katyo commented Apr 9, 2024

Still doesn't work both speakers and headphones on Teclast F5.
Seems hardware detected correctly but it still does not work as expected.
When I try to playback something (using audacious or chromium) it cannot start. Looks like synchronization does not work at all.
Seems digital microphone works just after boot (a level indicator shows some activity then I talk) but stop working after try to playback sound.

kernel: 6.8.4
dmesg:

[    5.436535] snd_hda_intel 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100
[    6.802611] snd_soc_skl 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100
[    6.864934] snd_soc_avs 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100
[    7.475064] sof-audio-pci-intel-apl 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100
[    7.475453] sof-audio-pci-intel-apl 0000:00:0e.0: DSP detected with PCI class/subclass/prog-if 0x040100
[    7.475616] sof-audio-pci-intel-apl 0000:00:0e.0: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[    7.516249] sof-audio-pci-intel-apl 0000:00:0e.0: use msi interrupt mode
[    7.637675] sof-audio-pci-intel-apl 0000:00:0e.0: NHLT_DEVICE_I2S detected, ssp_mask 0x5
[    7.637690] sof-audio-pci-intel-apl 0000:00:0e.0: Overriding topology with MCLK mask 0x2 from NHLT
[    7.637695] sof-audio-pci-intel-apl 0000:00:0e.0: hda codecs found, mask 4
[    7.690666] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware paths/files for ipc type 0:
[    7.690680] sof-audio-pci-intel-apl 0000:00:0e.0:  Firmware file:     intel/sof/sof-glk.ri
[    7.690684] sof-audio-pci-intel-apl 0000:00:0e.0:  Topology file:     intel/sof-tplg/sof-glk-es8336-ssp2.tplg
[    7.721379] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware info: version 2:2:0-57864
[    7.721391] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
[    7.721411] sof-audio-pci-intel-apl 0000:00:0e.0: unknown sof_ext_man header type 3 size 0x30
[    7.772716] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware info: version 2:2:0-57864
[    7.772729] sof-audio-pci-intel-apl 0000:00:0e.0: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
[    7.957263] sof-essx8336 sof-essx8336: quirk mask 0x2
[    7.957276] sof-essx8336 sof-essx8336: quirk SSP2
[    7.958342] sof-audio-pci-intel-apl 0000:00:0e.0: Topology: ABI 3:22:1 Kernel ABI 3:23:0
[    7.958667] sof-essx8336 sof-essx8336: ASoC: Parent card not yet available, widget card binding deferred
[    8.166233] input: sof-essx8336 Headset as /devices/pci0000:00/0000:00:0e.0/sof-essx8336/sound/card0/input12
[    8.166362] input: sof-essx8336 HDMI/DP,pcm=5 as /devices/pci0000:00/0000:00:0e.0/sof-essx8336/sound/card0/input13
[    8.166509] input: sof-essx8336 HDMI/DP,pcm=6 as /devices/pci0000:00/0000:00:0e.0/sof-essx8336/sound/card0/input14
[    8.166677] input: sof-essx8336 HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:0e.0/sof-essx8336/sound/card0/input15

@tshipenchko
Copy link

tshipenchko commented Apr 9, 2024

Everything works fine out of the box on huawei d14 (HUAWEI NBD-WXX9-PCB-B4) & latest kernel & latest alsa-ucm-conf
But I had to add this script at system startup:

#!/nix/store/r9h133c9m8f6jnlsqzwf89zg9w0w78s8-bash-5.2-p15/bin/bash
set -e
#!/usr/bin/env sh
# For "Pro Audio" profile
# amixer cset name='Headphone Switch' on
# amixer cset name='Speaker Switch' on
# amixer cset name='Headphone Playback Volume' 10,10
# amixer cset name='Right Headphone Mixer Right DAC Switch' on
# amixer cset name='Left Headphone Mixer Left DAC Switch' on
# amixer cset name='DAC Playback Volume' 999,999
# amixer cset name='Headphone Mixer Volume' 999,999
#
# amixer sset "Dmic0" 70
# amixer sset "Dmic1 2nd" 70

# For "Play and record HiFI quality Music" profile
# Enables Right and Left speakers
amixer cset name='Right Headphone Mixer Right DAC Switch' on
amixer cset name='Left Headphone Mixer Left DAC Switch' on

You can change your sound profile in pavucontrol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CML Applies to Comet Lake platform codec ES8336 codec Codec HW or driver restriction Community end-user or distro-reported issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests