Sdw/endpoint aggregation #1821
Merged
Sdw/endpoint aggregation #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plbossart
requested review from
dbaluta,
kv2019i,
lgirdwood and
ranj063
as code owners
lyakh
suggested changes
Feb 24, 2020
bardliao
reviewed
Feb 24, 2020
There was a problem hiding this comment.
LGTM @plbossart Just wondering if two rt1308 should be group in cml_3_in_1_default[]
plbossart
force-pushed
the
sdw/endpoint-aggregation
branch
from
084a4a9 to
8bd9fed
Compare
ranj063
reviewed
Feb 24, 2020
ranj063
reviewed
Feb 24, 2020
RanderWang
previously approved these changes
Feb 25, 2020
lyakh
reviewed
Feb 25, 2020
|
@plbossart I implemented a new solution based on this PR. It is much simple than my last one. I will create a PR when this PR is merged. |
For SoundWire, we need to know if endpoints needs to be 'aggregated' (MIPI parlance, meaning logically grouped), e.g. when two speaker amplifiers need to be handled as a single logical output. We don't necessarily have the information at the firmware (BIOS) level, so add a notion of endpoints and specify if a device/endpoint is part of a group, with a position. This may be expanded in future solutions, for now only provide a group and position information. Since we modify the header file, change all existing upstream tables as well to avoid breaking compilation/bisect. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
No new functionality, just indirection needed to access _ADR information. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
…ormation No new feature, just one additional layer of indirection. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/endpoint-aggregation
branch
from
8bd9fed to
2fad9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how we can expand the ACPI _ADR based information to clarify how endpoints can be logically grouped, e.g. handle 2 speaker amplifiers on separate links as a single logical output.
@RanderWang this is an alternative to your initial proposal, I believe it would simplify the decision to use multiple cpu-dais for link, essentially if you find a device with an aggregated endpoint you need more than one cpu-dai per dailink.
@bardliao please double check that the table values are consistent, I hope I didn't break too many things on a Friday afternoon :-)