Fix/sof hda split #300
Merged
Fix/sof hda split #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most inits can be conditionally included. the bus->reg_lock spinlock is required in all cases. TODO: remove the static variable (unclear why it's needed) Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
…ined Make bus and hlink variables conditionally declared Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This code isn't tested, let's remove it and re-add later if needed Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Make rb conditional on SOF_HDA and add missing free on release. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Use static inlines to make code simpler. i915 is only enabled/used when both SOF_HDA and SOC_HDAC_HDMI are used. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
-Wunused-variable should be an error Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up and extends initial contributions from #257
I will merge it without reviews so that we have all the known improvements for HDaudio in topic/sof-dev. we are taking too much time to make progress on such cleanups.