ASoC: sdca: test adev before calling acpi_dev_for_each_child #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
lgirdwood,
plbossart,
kv2019i and
dbaluta
as code owners
ujfalusi
reviewed
Nov 11, 2024
sound/soc/sdca/sdca_functions.c
Outdated
| @@ -165,6 +165,10 @@ void sdca_lookup_functions(struct sdw_slave *slave) | |||
| struct device *dev = &slave->dev; | |||
| struct acpi_device *adev = to_acpi_device_node(dev->fwnode); | |||
|
|
|||
| if (!adev) { | |||
| dev_dbg(dev, "Not an ACPI device\n"); | |||
There was a problem hiding this comment.
I would move this to info level to be visible and rephrase the print to something like 'No matching ACPI device found, ignoring peripheral`
There was a problem hiding this comment.
Btw, do you need/want Fixes tag?
There was a problem hiding this comment.
Btw, do you need/want Fixes tag?
Yes, done.
ujfalusi
approved these changes
Nov 12, 2024
lgirdwood
approved these changes
Nov 12, 2024
sdca_lookup_functions may be called by a Peripheral that is not listed in the ACPI table. Testing adev is required to avoid kernel NULL pointer dereference. Fixes: 3a513da ("ASoC: SDCA: add initial module") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
ujfalusi
approved these changes
Nov 12, 2024
ranj063
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdca_lookup_functions may be called by a Peripheral that is not listed in the ACPI table. Testing adev is required to avoid kernel NULL pointer dereference.