hijack.sh: fail when an error is found in firmware logs

At last. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
thesofproject · Jul 1, 2023 · 2f8bc05 · 2f8bc05
1 parent 111906b
commit 2f8bc05
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/case-lib/hijack.sh b/case-lib/hijack.sh
@@ -111,6 +111,10 @@ function func_exit_handler()
                 dloge "Empty logfile"
                 exit_status=1
             fi
+
+            check_error_in_fw_logfile "$logfile" ||
+                exit_status=1
+
         else
             dloge "Log file not found: $logfile"
             exit_status=1

diff --git a/case-lib/lib.sh b/case-lib/lib.sh
@@ -437,7 +437,10 @@ check_error_in_fw_logfile()
     if (set -x
         grep -B 2 -A 1 -i --word-regexp -e 'ERR' -e 'ERROR' -e '<err>' "$1"
        ); then
-       return 1
+        # See internal Intel bug #448
+        dlogw 'An HTML display bug hides the bracketed Zephyr &lt;loglevels&gt; in this tab,'
+        dlogw 'switch to the tab with the complete logs to see the log levels.'
+        return 1
     fi
 }