Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple-pipeline-{capture,playback}.sh are broken #324

Closed
lyakh opened this issue Aug 7, 2020 · 3 comments
Closed

multiple-pipeline-{capture,playback}.sh are broken #324

lyakh opened this issue Aug 7, 2020 · 3 comments
Labels
type:bug Something doesn't work as expected

Comments

@lyakh
Copy link
Contributor

lyakh commented Aug 7, 2020

The multiple-pipeline-playback.sh and multiple-pipeline-capture.sh scripts are broken, they do nothing. They check $PIPELINE_COUNT before parsing topology by calling func_pipeline_export

@lyakh lyakh added the type:bug Something doesn't work as expected label Aug 7, 2020
@lyakh lyakh changed the title multiple-pipeline-playback.sh is broken multiple-pipeline-{capture,playback}.sh are broken Aug 7, 2020
@plbossart
Copy link
Member

@lyakh do you mean to say that this line is wrong?

[[ $PIPELINE_COUNT -gt ${OPT_VALUE_lst['c']} ]] && max_count=${OPT_VALUE_lst['c']} || max_count=$PIPELINE_COUNT
f

I must say I have zero understanding of these scripts.

@lyakh
Copy link
Contributor Author

lyakh commented Sep 1, 2020

@lyakh do you mean to say that this line is wrong?

[[ $PIPELINE_COUNT -gt ${OPT_VALUE_lst['c']} ]] && max_count=${OPT_VALUE_lst['c']} || max_count=$PIPELINE_COUNT
f

I must say I have zero understanding of these scripts.

@plbossart it isn't about the contents of that line, it's about when it is executed, respectively when the $PIPELINE_COUNT variable is evaluated. Evaluating it before it is set makes no sense and it is only set in func_pipeline_export()

@aiChaoSONG
Copy link

@lyakh This is fixed by #380, thanks. let's close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something doesn't work as expected
Projects
None yet
Development

No branches or pull requests

3 participants