-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-case: add missing pipeline count acquisition logic #380
Conversation
Forgot to mention it's intermittently empty on my Up2 board. This fix does not look like a fix for a non-deterministic issue... @aiChaoSONG what's your logger experience when running the multipipeline tests? Before and after this PR? UPDATE after a bit more testing: not intermittently empty: empty the second time I run |
8d877a9
to
3605f6a
Compare
@marc-hb Before this PR, the test case always PASS, even the topology not loaded(should fail), and the terminal message like this:
After this PR, if topology loaded, terminal message looks like this: In fact, before this PR, no pipeline is checked, that's why it always pass. |
3605f6a
to
b711898
Compare
The commit 84f5895 wrongly remove the code logic to acquire pipeline count from multi-pipeline-playback/ capture test cases. This leads to the 'max_count' used in these scripts being empty, as no pipeline is actually tested, the test cases will always pass. This patch adds the pipeline count acquisition logic back. Signed-off-by: Amery Song <chao.song@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting it.
merge for tgl release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix
The commit 84f5895 wrongly remove the code logic to
acquire pipeline count from multi-pipeline-playback/
capture test cases. This leads to the 'max_count' used
in these scripts being empty, as no pipeline is actually
tested, the test cases will always pass.
This patch adds the pipeline count acquisition logic back.