kmod: add more SoundWire codecs #1110
Conversation
|
Warning: "all checks have passed" is misleading: sof-test has NOT run yet. Internal throttling issue 480 Downgrading to draft until they have. |
|
check-kmod-load-unload.sh failures across the boards in both stable-v2.2 and cavs25 https://sof-ci.01.org/softestpr/PR1110/build777/devicetest/index.html Most or maybe all of them are: |
|
@charleskeepax @rfvirgil any idea why the dependencies are different between CS42l43 and other codecs? |
|
The error message you state seems expected to me: snd_soc_cs42l43 - this is the core modules holds the control bus independent code. I would expect you would need to remove the core module before you remove the soundwire one as the core calls into the soundwire code for things like dai ops. One could theoretically arrange the code the other way around but it gets really messy with having to have duplicate dai_driver struct etc. |
|
I guess the difference here is the actual bus level code would be the other way around (soundwire code calls the core), but since cs42l43 is an MFD the bus level code lives in MFD. |
rt722-sdca, rt1017-sdca and CirrusLogic missing The CS42L43 order is inverted, the core calls into the -sdw module Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
kmod/sdw-codecs
branch
from
1c37867
to
cbf427d
Compare
|
Thans @charleskeepax I inverted the order, let's see how things go. |
|
Now fails most cavs2.5 and stable-v2.2 like this: Just realized this test hasn't been re-added to ACE yet: EDIT: now added. Will run again. |
|
SOFCI TEST |
There was a problem hiding this comment.
Now MTL/ACE is failing like the others:
https://sof-ci.01.org/softestpr/PR1110/build791/devicetest/index.html?model=MTLP_RVP_SDW&testcase=check-kmod-load-unload
RMMOD snd_soc_core
rmmod: ERROR: Module snd_soc_core is in use by: snd_soc_wm_adsp
|
SOFCI TEST |
|
new daily kernel build is available. Triggered new test again |
|
the device test is going on, no MTLP_RVP_NOCODEC. jf-mtlp-rvp-nocodec-2 had apt package tangled problem. fixed on the device |
|
Thanks @fredoh9 . Still failing in https://sof-ci.01.org/softestpr/PR1110/build796/devicetest/index.html , https://sof-ci.01.org/softestpr/PR1110/build794/devicetest/index.html and https://sof-ci.01.org/softestpr/PR1110/build795/devicetest/index.html of course, no change |
|
SOFCI TEST |
|
Still failing with |
|
There is a git conflict now. |
|
@bardliao could you rebase and resubmit this? |
sure |
rt722-sdca, rt1017-sdca and CirrusLogic missing
Note for for CirrusLogic we may have additional dependencies on MFD stuff.