Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.sh: workaround "sudo ... &" corruption issue 1151 for stable-v2.2 #1221

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jul 12, 2024

Should finally fix terminal corruption issue #1151.

Commit 8341638 was a good workaround but it was applied only for Zephyr's mtrace.

  • Apply the same workaround for stable-v2.2 sof-logger
  • Explain better in the source what causes the corruption
  • Change owner of mtrace.txt logs to "ubuntu" instead of root.

Should finally fix terminal corruption issue thesofproject#1151.

Commit 8341638 was a good workaround but it was applied only for
Zephyr's mtrace.

- Apply the same workaround for stable-v2.2 sof-logger
- Explain better in the source what causes the corruption
- Change owner of mtrace.txt logs to "ubuntu" instead of root.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review July 12, 2024 01:29
@marc-hb marc-hb requested a review from a team as a code owner July 12, 2024 01:29
@marc-hb marc-hb requested review from ssavati and fredoh9 July 12, 2024 01:30
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 12, 2024

Usual LNL failures in https://sof-ci.01.org/softestpr/PR1221/build639/devicetest/index.html

Everything else green.

Copy link
Collaborator

@fredoh9 fredoh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My terminal output has much cleaner.

@fredoh9
Copy link
Collaborator

fredoh9 commented Jul 16, 2024

BTW, separate and side note,

Can you figure out check-xrun-injection.sh \r\n vs \n issue?

check-xrun-injection.sh
2024-07-16 19:29:03 UTC Sub-Test: [INFO] Testing: test xrun injection on PCM:pcm3c,capture. Interval time: 0.5
2024-07-16 19:29:03 UTC Sub-Test: [COMMAND] arecord -Dhw:0,3 -r 48000 -c 4 -f S16_LE /dev/null -q
2024-07-16 19:29:03 UTC Sub-Test: [COMMAND] echo 1 > /proc/asound/card0/pcm3c/sub0/xrun_injection
2024-07-16 19:29:03 UTC Sub-Test: [INFO] XRUN injection: 1
overrun!!! (at least 0.117 ms long)
                                   2024-07-16 19:29:04 UTC Sub-Test: [INFO] XRUN injection: 2
overrun!!! (at least 0.176 ms long)
                                   2024-07-16 19:29:04 UTC Sub-Test: [INFO] XRUN injection: 3
overrun!!! (at least 0.048 ms long)
                                   2024-07-16 19:29:05 UTC Sub-Test: [INFO] XRUN injection: 4
overrun!!! (at least 0.094 ms long)
                                   2024-07-16 19:29:06 UTC Sub-Test: [INFO] XRUN injection: 5
overrun!!! (at least 0.098 ms long)
                                   2024-07-16 19:29:06 UTC Sub-Test: [COMMAND] kill process: kill -9 10011
2024-07-16 19:29:06 UTC Sub-Test: [INFO] Testing: test xrun injection on PCM:pcm4c,capture. Interval time: 0.5

@marc-hb marc-hb merged commit 1b635c3 into thesofproject:main Jul 16, 2024
6 of 7 checks passed
@marc-hb marc-hb deleted the sudo-term-corrupt branch July 16, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants