-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: exit successfully if call trace is not from alsa #208
Conversation
f546449
to
c6d1050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost is good
Previouly, every call trace will fail the test case, that's not correct. Only ALSA related call trace should fail the test case. This patch checks call trace message, and only failed test case with ALSA related call trace. Signed-off-by: Amery Song <chao.song@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring the code style issues for now, this change ignores every single non-snd
Call Trace in every test, correct? That's extremely dangerous. Issue #167 is about ignoring one specific trace in one specific test.
More generally speaking, could the majority of this script be replaced by something much shorter like this?
journalctl --dmesg -p 3 | grep -v -e '$ignore_issue_123" -e "$ignore_dma_trace"
@marc-hb Sorry for made a mistake. the issue should be #184 , not #167. #184 reported "a none SOF call trace caused one test case failed", but in fact that call trace is related to sound. As you said, ignore all call traces other than sound is dangerous. Let's close this for the issue is related to sound. I will try to use |
@Bin-QA I think Marc's suggestion is good, is there any possibility to use this: |
how to clean buffer? @aiChaoSONG it can use for upgrade: tools/sof-kernel-dump.sh |
test3_start=$(date +%s)
run_test3
test3_end=$(date +%s)
journalctl --boot --since=@"$test3_start" --until=@"$test3_end"
|
Longer example test3_start=$(date +%s)
run_test3
test3_end=$(date +%s)
# Errors or worse
journalctl --boot --since=@"$test3_start" --until=@"$test3_end" -p 3
# Warnings only
journalctl --boot --since=@"$test3_start" --until=@"$test3_end" -p 4..4 |
Previouly, every call trace will fail the test
case, that's not correct. Only ALSA related
call trace should fail the test case.
This patch checks call trace message, and
only failed test case with ALSA related
call trace.
fix #184