Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: fix misleading pipeline exporting info #359

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

aiChaoSONG
Copy link

The "No available topology ..." info is misleading,
this patch makes it clearer.

Fixes: #232

Signed-off-by: Amery Song chao.song@intel.com

@aiChaoSONG aiChaoSONG requested a review from a team as a code owner September 2, 2020 08:09
@@ -8,7 +8,7 @@ func_pipeline_export()
fi
# got tplg_file, verify file exist
tplg_path=$(func_lib_get_tplg_path "$1") || {
die "No available topology for pipeline export"
die "No topology found! Please configure TPLG env to point to you topology path."
Copy link
Collaborator

@marc-hb marc-hb Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many tests seem to have a -t option so setting TPLG is not the only possible solution.

It looks like this new error message will ask me to set TPLG even when I make a typo in TPLG. That's confusing. It will also not show my typo.

How about:

die "Topology $1 not found, check the TPLG environment variable" 

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb The default value for -t option is $TPLG. if No TPLG is set, and -t not specified, the "$1" will be empty. How about this: Topology not found, check TPLG environment variable or specify topology path with -t

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • if $1 is empty: Topology not found, check TPLG
  • if $1 is wrong: Topology wrong_file not found, check TPLG.

I don't mind mentioning -t in the message but it should also print $1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the -t in the message, updated

The "No available topology ..." info is misleading,
this patch makes it clearer.

Fixes: thesofproject#232

Signed-off-by: Amery Song <chao.song@intel.com>
@aiChaoSONG aiChaoSONG merged commit 31039cc into thesofproject:master Sep 7, 2020
@aiChaoSONG aiChaoSONG deleted the fix_unclear_info branch September 8, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misleading error report of 'no available topology'
2 participants