intel_adsp: ptl: Fix SOF compilation without PM #9203
Conversation
pjdobrowolski
requested review from
tmleman,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
There was a problem hiding this comment.
@pjdobrowolski are we pending some other patch hence the DNM ?
PTL has CONFIG_PM disabled. SOF should still build without this configuration flag. This patch fixes the compilation issue. Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>
|
@pjdobrowolski Same question Liam, why the DNM in title? I don't see any hard dependencies and it would seem we can merge this right away. |
|
Because it is commit taken from #9185 only for CI purpose. |
You're confusing "Continuous Integration" and "PR tests". The latter is only a small part of the former. There are also daily tests which run only on merged code. Also, merged code is "tested" by all developers who update their branches. "Integrating" == merging (smaller) bits of code. Also, merging this one can make 9185 smaller PS: I wrote "Continuous Integration" in 9185 and recommended to extract this. |
Its good to fix build without this kconfig but the question is why it is disabled? @jxstelter @tmleman |
pjdobrowolski
changed the title
|
@marc-hb removed dnm, ready to merge. |
Originally during PTL development we started with CONFIG_PM disabled but the fix was just allowing to compile with this config flag cleared, By default it should be set anyway for PTL. |
|
@lgirdwood @kv2019i I think that PR is ready to merge. |
There was a problem hiding this comment.
The git message is still not very accurate as this has nothing to do with "ptl" and this touches multiple places in the code, so the "intel_adsp:" prefix is not accurate either. But I guess one gets the point from the commit message, so let me go ahead and merge this. I think this is useful capability to be able to build without CONFIG_PM.
PTL has CONFIG_PM disabled. SOF should still build without this configuration flag. This patch fixes the compilation issue.