Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology2: fix LNL RT712 and RT722 HDMI dailink index #9302

Closed
wants to merge 1 commit into from

Conversation

plbossart
Copy link
Member

There's no amp feedback so the indices are off-by-one compared to the default. This should be the index map on these boards:

0: headphone
1: headset
2: speakers
3: mic
4..6: HDMI

Closes: #9295

@plbossart plbossart requested review from ranj063 and jsarha as code owners July 15, 2024 08:19
@wszypelt
Copy link

@plbossart Hi, in internal intel CI system, cmake tools failed at syntax error. I think this can be a issue:
image

There's no amp feedback so the indices are off-by-one compared to the
default. This should be the index map on these boards:

0: headphone
1: headset
2: speakers
3: mic
4..6: HDMI

Closes: thesofproject#9295
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart plbossart force-pushed the topology/lnl-hdmi branch from e441be7 to d960e34 Compare July 16, 2024 10:02
@bardliao
Copy link
Collaborator

@plbossart We have #define SOC_SDW_DMIC_DAI_ID 4, I think the mic be id is expected to be 4 no matter amp feedback is there or not. Maybe we should check what is wrong on kernel side?

@plbossart plbossart marked this pull request as draft July 16, 2024 14:21
@plbossart
Copy link
Member Author

moved back to draft, it seems the BIOS settings are not correct?

Copy link
Collaborator

@bardliao bardliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will fix #9295. Please see the dmesg log below

[    5.453986] snd_soc_sof_sdw:sof_card_dai_links_create: sof_sdw sof_sdw: sdw 4, ssp 0, dmic 2, hdmi 0, bt: 0
[    5.453989] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link SDW0-Playback-SimpleJack, id 0
[    5.454027] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link SDW0-Capture-SimpleJack, id 1
[    5.454030] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link SDW0-Playback-SmartAmp, id 2
[    5.454032] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link SDW0-Capture-SmartMic, id 4
[    5.454033] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link dmic01, id 5
[    5.454035] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link dmic16k, id 6
[    5.454037] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link iDisp1, id 7
[    5.454038] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link iDisp2, id 8
[    5.454040] snd_soc_sdw_utils:asoc_sdw_init_dai_link: sof_sdw sof_sdw: create dai link iDisp3, id 9

@plbossart
Copy link
Member Author

this PR is not needed, closing

@plbossart plbossart closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] LNL RT712 and LNL RT722 fails to load topology
4 participants