Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] fix for 9343 Failed "assert(buffer->is_shared)" in fuzzing #9356

Merged
merged 2 commits into from
Aug 14, 2024
Merged

[RFC] fix for 9343 Failed "assert(buffer->is_shared)" in fuzzing #9356

merged 2 commits into from
Aug 14, 2024

Conversation

marcinszkudlinski
Copy link
Contributor

No description provided.

@marcinszkudlinski
fix: remove cache ops for coherent architectures
42ebb34 
For cache alignment, PLATFORM_DCACHE_ALIGN is a better macro
than DCACHE_LINE_SIZE (for some compilations not even defined)

For CONFIG_INCOHERENT=0 compilation, it does not make any sense
to call writeback/invalidate operations

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski
buf: fixes for CONFIG_INCOHERENT=0 builds
10f8c6b 
there's no point with cache writeback/invalidate
for coherent architectures. Also the buffer may be set
as "shared" at any moment, not only at creation time

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski marcinszkudlinski changed the title Config incoherent [DNM] fix for Aug 9, 2024
@marcinszkudlinski marcinszkudlinski changed the title [DNM] fix for [RFC] fix for https://github.com/thesofproject/sof/issues/9343 Aug 9, 2024
@marcinszkudlinski marcinszkudlinski mentioned this pull request Aug 9, 2024
Open
@marcinszkudlinski marcinszkudlinski added the bug Something isn't working as expected label Aug 9, 2024
@marcinszkudlinski marcinszkudlinski marked this pull request as ready for review August 9, 2024 10:42
lgirdwood
lgirdwood approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I think we have minimal users of coherent.h now as transition away is almost complete. We should be able to delete coherent.h at some point.

tmleman
tmleman approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@tmleman tmleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to reproduce this issue in my local environment.

@marc-hb marc-hb changed the title [RFC] fix for https://github.com/thesofproject/sof/issues/9343 [RFC] fix for 9343 Failed "assert(buffer->is_shared)" in fuzzing Aug 9, 2024
@kv2019i
Copy link
Collaborator

kv2019i commented Aug 14, 2024

SOFCI TEST

@kv2019i kv2019i merged commit 6c29ad3 into thesofproject:main Aug 14, 2024
46 of 47 checks passed
@marcinszkudlinski marcinszkudlinski deleted the CONFIG_INCOHERENT branch August 14, 2024 14:58
@marc-hb marc-hb mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmleman tmleman tmleman approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@bardliao bardliao Awaiting requested review from bardliao bardliao is a code owner

@pblaszko pblaszko Awaiting requested review from pblaszko pblaszko is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

Assignees
No one assigned
Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcinszkudlinski @kv2019i @lgirdwood @tmleman