Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: intel_adsp_ace20_lnl.conf: clean up board config file #9620

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Oct 28, 2024

Group the configuration options per theme, separate SOF and Zephyr Kconfig settings and order the entries in alphabetical order within each group. This makes the board config file much more readable and easy to maintain.

Resulting board file (as diff is a bit hard to read): https://github.com/kv2019i/sof/blob/0e04e7eb9186bbd07497d41737c5d435adf1a388/app/boards/intel_adsp_ace20_lnl.conf

Group the configuration options per theme, separate SOF and Zephyr
Kconfig settings and order the entries in alphabetical order within
each group. This makes the board config file much more readable and
easy to maintain.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 28, 2024

@tmleman and others: I now separated SOF and Zephyr config options in this PR. If this looks better, I can rework the MTL board file as well using this grouping.

Copy link
Contributor

@tmleman tmleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the great work. Comparing MTL with LNL now, I see the advantages of keeping settings that are related (such as those related to logging) in groups. But ultimately, the version with the division into SOF and Zephyr is, in my opinion, better.

@kv2019i kv2019i merged commit 1edcd91 into thesofproject:main Oct 28, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants