Tools: Topology2: Intel: Add enhanced speaker and DMIC processing to SDW PCs #9652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
commented
Nov 14, 2024
The control names for volume in host and ALH DAI pipelines are aligned with other topologies with Pre Mixer and Post Mixer prefixes. The name Amplifier is changed to more descriptive "Speaker Playback". The names become after change: - "Pre Mixer Speaker Playback Volume" - "Post Mixer Speaker Playback Volume" Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds to ALH pipeline between gain and ALH processing with IIR, FIR, and DRC. The change is intended for topologies for PCs running Linux OS. Topologies with enable enhanced playback are currently: - sof-mtl-rt713-l0-rt1316-l12.tplg - sof-lnl-rt722-l0.tplg The change adds in MTL platform 4.2 MCPS load to speaker playback in pass-through mode. With highpass IIR and default speaker DRC the load increase is 45 MCPS. Other topologies than above have no MCPS increase. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds to all topologies with SDW DMIC the module copier to in ALH copier pipeline after the IIR equalizer. The module copier allows to duplicate the stream for several post-processing pipelines as analogy with mixin/mixout in playback pipelines. When SDW_DMIC_ENHANCED_CAPTURE is set "true" in topology build the multi-microphone beamformer (TDFB) and dynamic range control (DRC) components are added to host pipeline. The capture pre-processing is enabled for PC topology sof-lnl-rt722-l0.tplg. The beamformer is set for a narrow opening stereo image suitable for notebook user voice enhance. The DRC is set for a default DMIC level boost. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tplg_sdw_add_enhanced_speaker_mic
branch
from
04b0c72
to
86e992c
Compare
singalsu
changed the title
lgirdwood
reviewed
Nov 14, 2024
|
Here's pictures of topologies. The added components are marked:
|
I have the upper type of device that is without microphone, so I can't demonstrate the capture enhance. But I can make some recording demo of playback with DRC on/off. If I'm able to measure the speaker response I can also demo the EQ on/off. The current 100 Hz high-pass filter is not audible though it helps to reduce speaker distortion when playing loud. |
ranj063
reviewed
Nov 14, 2024
| @@ -0,0 +1,199 @@ | |||
| # | |||
There was a problem hiding this comment.
@singalsu lets update this to use the subtreecopy construct like we discussed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.