[SKIP SOFCI-TEST] topology: build using a local ALSA install #9870
Conversation
lgirdwood
requested review from
ranj063,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
This wont pass CI yet, pending a alsa-utils fix to upstream 1st before merge. |
scripts/build-alsa-tools.sh
Outdated
| # Array of ALSA Git repository URLs. Add or remove repositories as needed. | ||
| declare -a REPOS=( | ||
| "https://github.com/alsa-project/alsa-lib.git" | ||
| "https://github.com/alsa-project/alsa-utils.git" |
There was a problem hiding this comment.
Btw, the docker script for alsa-utils has built ALSA from thesofproject repos of alsa-lib and alsa-utils. I don't see an issue using upstream repos though, just as long we capture the commit-id to build in SOF side to ensure only versions we have validated are used.
| @@ -1,18 +1,19 @@ | |||
| set(SOF_TOPOLOGY_BINARY_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}") | |||
|
|
|||
| set(SOF_ALSA_TOOLS_DIR "${SOF_ROOT_SOURCE_DIRECTORY}/../tools/bin") | |||
| set(ALSATPLG_CMD "${SOF_ALSA_TOOLS_DIR}/alsatplg") | |||
There was a problem hiding this comment.
It seems this is passing Windows CI runs, so apparently there's no attempt to run this (which is good).
We do need to add a call to new build script somewhere in our build flows, and somewhere that is specific to Linux. E.g. our SOF jenkins build now failing:
https://sof-ci.01.org/sofpr/PR9870/build11207/build/topology/tplg.log
CMake Warning at topology/CMakeLists.txt:16 (message):
/home/sof/work/sof.git/tools/../../tools/bin/alsatplg --version returned
status: No such file or directory,
There was a problem hiding this comment.
This is due to the missing alsa-utils patch
There was a problem hiding this comment.
fixed that part for github workflows that doen't use Docker
lgirdwood
force-pushed
the
lrg/topic/local-alsa
branch
2 times, most recently
from
e5c19f6 to
1cf54d0
Compare
lgirdwood
force-pushed
the
lrg/topic/local-alsa
branch
8 times, most recently
from
838b80a to
b3670cb
Compare
lgirdwood
changed the title
lgirdwood
force-pushed
the
lrg/topic/local-alsa
branch
9 times, most recently
from
ac138c8 to
8f6c110
Compare
lgirdwood
force-pushed
the
lrg/topic/local-alsa
branch
10 times, most recently
from
11ad0e1 to
da8184e
Compare
This script builds a local installation of ALSA lib and associated ALSA utilities that does not impact the system ALSA installation. This will enable a later update to locally build topologies without using the docker container. Signed-off-by: Liam Girdwood <liam.r.girdwood@intel.com>
Add a command line option to rebuild the ALSA libraries and tools required to build all topologies. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Update testbench to build without docker and use a local ALSA lib and ALSA utils version from SOF ALSA git to align with latest topology developments. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Dont use the system ALSA installation which may be out of date with current topology development. Use the locally installed ALSA lib and utils installed in the SOF workspace. Signed-off-by: Liam Girdwood <liam.r.girdwood@intel.com>
The installer workflow uses the legacy SDK build tools and is no longer valid for Zephyr based SDK migration. This also reduces effort in maintaining a SOF Docker container. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
force-pushed
the
lrg/topic/local-alsa
branch
from
da8184e to
136240c
Compare
Build topologies using a locally installed ALSA lib and ALSA utils without having to use Docker or upgrade the system ALSA installation.