This repository has been archived by the owner on Jan 17, 2019. It is now read-only.
kmod_scripts: extend the delay to ensure that hardware is ready for n… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
suggested changes
Jul 19, 2018
plbossart
reviewed
Jul 19, 2018
| @@ -3,7 +3,7 @@ | |||
| dmesg -C | |||
| ./sof_remove.sh | |||
| ./sof_insert.sh | |||
| sleep 1 | |||
| sleep 6 | |||
There was a problem hiding this comment.
Also not clear why this is needed. 1 second is plenty on all the platforms I have. in what cases do you need 6s?
There was a problem hiding this comment.
just run: sudo ./sof_bootloop.sh
…ext remove The delay is too short to let hardware get ready, in this case, system will be hang after 1-2 loops. After lot of tests, set the delay to 6s will avoid this issue on each platform. Signed-off-by: Zhang Keqiao <keqiao.zhang@linux.intel.com>
|
@plbossart |
|
@keqiaozhang There is currently a bug in the module load/unload on Baytrail, I don't know how you managed to run bootloop.sh when the kernel crashes anyways. see thesofproject/linux#33 |
|
I suggest we close this PR, there's been no activity in 20 days and there is no consensus it's useful. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ext remove
Signed-off-by: Zhang Keqiao keqiao.zhang@linux.intel.com