Skip to content
This repository has been archived by the owner on Mar 19, 2021. It is now read-only.

Add Android Touchpad Only Control Option #130

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Add Android Touchpad Only Control Option #130

merged 1 commit into from
Dec 24, 2019

Conversation

FearlessSpiff
Copy link
Contributor

Hi

Thanks for this great app, I only had one problem with it on Android:

I added an option to use the touchpad button without anything else on the android client. As the DS4 controller is only supported in Andorid 10 it helps as a workaround for all those trying to play with the DS4 with games using also the touchpad (Jedi, Fallen Order for me atm :-)). Maybe also other controllers. Tested it with my Pixel 3 and Tab S6. So with this PR you are able to play without on screen controls but just show the touchpad button in the bottom right.

Maybe you can incorporate it. It surely isn't the cleanest solution. And as I am new to Andorid Apps, I am open to suggestions. If they are not too time consuming as I have kids, a.s.o... ;-)

Thanks for considering
Spiff

@thestr4ng3r
Copy link
Owner

thestr4ng3r commented Dec 23, 2019

Doesn't look too bad, I think it makes sense to have this extra control layout with controls that might not be available on the physical controller. I will check it in detail tomorrow.
Only one request for now though: Please only use tabs in Kotlin code, TouchpadOnlyFragment.kt currently has spaces.

Btw don't worry about the failing travis job, I have yet to fix this for prs.

@FearlessSpiff
Copy link
Contributor Author

Only one request for now though: Please only use tabs in Kotlin code, TouchpadOnlyFragment.kt currently has spaces.

Ugh... I fixed it in my initial branch based on your repo. Then I forked and forgot it. Will change it with a
ammend/force push. I think Android Studio settings default to spaces, that's why...

@FearlessSpiff
Copy link
Contributor Author

Btw don't worry about the failing travis job, I have yet to fix this for prs.

Great. My local builds worked so far...

@thestr4ng3r
Copy link
Owner

Works fine for me, thanks!

@thestr4ng3r thestr4ng3r merged commit 385a382 into thestr4ng3r:master Dec 24, 2019
@FearlessSpiff
Copy link
Contributor Author

Cool! :-)

@FearlessSpiff FearlessSpiff deleted the add-android-touchpad-only-option branch December 24, 2019 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants