Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: track component props #56

Closed
1 task done
thetarnav opened this issue Aug 6, 2022 · 0 comments · Fixed by #107
Closed
1 task done

debugger: track component props #56

thetarnav opened this issue Aug 6, 2022 · 0 comments · Fixed by #107
Labels
enhancement New feature or request priority Important issue to focus on currently

Comments

@thetarnav
Copy link
Owner

thetarnav commented Aug 6, 2022

The debugger needs a way to track component props. Since they do not exist as an instance in the reactive graph, a special hook is necessary to track them. Later to be automatically injected by a babel transform.

The tricky part here is not necessarily getting to the props object—it'll be done one way or another—but "subscribing" to the properties without interfering with the reactive graph.

The props object could probably be added to the owner object when the component is created in dev. (so no babel plugin for this one)
Then the props object would be mapped for the selected component every time the walker executes—instead of tracking the props signals with computations. This is to avoid interfering with the reactive graph by reading memos/signals in a tracking context. Lazy memos would over-execute, and the new pull-push mechanic in 1.5 would be messed with here as well. Parsing the props outside of the queue and untracked should reduce any potential issues.

TODO:

@thetarnav thetarnav added enhancement New feature or request priority Important issue to focus on currently labels Aug 6, 2022
@thetarnav thetarnav changed the title debugger: debugProps hook debugger: track component props Aug 28, 2022
@thetarnav thetarnav mentioned this issue Sep 3, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority Important issue to focus on currently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant