Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component props #107

Merged
merged 19 commits into from
Sep 16, 2022
Merged

Component props #107

merged 19 commits into from
Sep 16, 2022

Conversation

thetarnav
Copy link
Owner

@thetarnav thetarnav commented Sep 3, 2022

tracking, displaying and updating component props in the details side panel.

Closes #56

image

Requires solidjs/solid#1204 to work.

TODO:

  • parse the props in the tree walker
  • reconcile props on the extension end
  • display the props in the extension
  • allow for collapsing nested prop values
  • fix reconciliation of nested values (maybe tests are needed after all)
  • send only prop values, instead of the whole details
  • highlight hovered HTML elements
  • improve props display styles
  • add changeset

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2022

🦋 Changeset detected

Latest commit: 327f627

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@solid-devtools/debugger Minor
@solid-devtools/ext-adapter Minor
solid-devtools-extension Minor
@solid-devtools/shared Patch
@solid-devtools/ui Patch
@solid-devtools/locator Minor
@solid-devtools/logger Patch
solid-devtools Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thetarnav thetarnav mentioned this pull request Sep 3, 2022
1 task
@thetarnav thetarnav marked this pull request as ready for review September 6, 2022 19:17
@thetarnav
Copy link
Owner Author

Waiting for the next solid release before merging.

@thetarnav thetarnav merged commit 1abd00e into main Sep 16, 2022
@thetarnav thetarnav deleted the component-props branch September 16, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debugger: track component props
1 participant