Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: observe stores #157

Merged
merged 35 commits into from
Nov 11, 2022
Merged

Feature: observe stores #157

merged 35 commits into from
Nov 11, 2022

Conversation

thetarnav
Copy link
Owner

@thetarnav thetarnav commented Oct 23, 2022

Closes #21

Depends on solid PR: solidjs/solid#1307

TODO:

  • make sure solid-js is moved to devDeps (waiting fo pr to solid to be merged)
  • reset sandbox to original state
  • fix tests
  • add changeset
  • remove console logs (fixes Add eslint #158)
  • try implementing updates in solid as global—so that they could be listened to without patching stores
  • display the store nodes in a unique way, so that they are able to be identified
  • separate memos from stores and signals in the inspector
  • use chevron arrows to identify extendable values (fixes Add an arrow collapse indicator to inspector values #148)
  • prevent expanding (inspecting) non-object signals
  • update the store value as it's changing
  • handle shared references in the same store
  • show fine-grain updates to the store
  • handle stores in props
  • improve tracking props (fixes throttle updating the values of props #150)
  • remove wrapStores transform
  • fix computation values not updating

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2022

🦋 Changeset detected

Latest commit: 15e4456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@solid-devtools/transform Minor
@solid-devtools/debugger Minor
@solid-devtools/shared Minor
@solid-devtools/logger Minor
solid-devtools Minor
solid-devtools-extension Minor
@solid-devtools/frontend Minor
@solid-devtools/overlay Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thetarnav thetarnav marked this pull request as ready for review November 6, 2022 12:22
@thetarnav thetarnav merged commit 4db2667 into main Nov 11, 2022
@thetarnav thetarnav deleted the feat/observe-stores branch November 11, 2022 10:49
@thetarnav thetarnav mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant