Skip to content
This repository has been archived by the owner on Jun 4, 2020. It is now read-only.

chore(ci): use partials in circleci config #359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(ci): use partials in circleci config #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@ version: 2.1
orbs:
saucelabs: saucelabs/sauce-connect@1.0.1

partials:
node-image: &node-image circleci/node:12.14.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could define it as an executor instead of using yaml references.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed in this case it would be more efficient to define an executor


jobs:
yarn-install:
docker:
- image: circleci/node:12.14.1
- image: *node-image
steps:
- checkout
- restore_cache:
Expand All @@ -29,7 +32,7 @@ jobs:

lint:
docker:
- image: circleci/node:12.14.1
- image: *node-image
steps:
- checkout
- attach_workspace:
Expand All @@ -54,7 +57,7 @@ jobs:

build:
docker:
- image: circleci/node:12.14.1
- image: *node-image
steps:
- checkout
- attach_workspace:
Expand All @@ -69,7 +72,7 @@ jobs:

unit-tests:
docker:
- image: circleci/node:12.14.1
- image: *node-image
steps:
- checkout
- attach_workspace:
Expand All @@ -80,7 +83,7 @@ jobs:

functional-tests:
docker:
- image: circleci/node:12.14.1
- image: *node-image
environment:
DATABASE_HOST: localhost
DATABASE_USER: thetribe
Expand Down