Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocketClient ignores options unless it has a tlsOptions property #177

Closed
robatwilliams opened this issue Jan 9, 2015 · 0 comments
Closed
Assignees
Milestone

Comments

@robatwilliams
Copy link

if (config && config.tlsOptions) {
        var tlsOptions = config.tlsOptions;
        delete config.tlsOptions;
        extend(this.config, config);
        extend(this.config.tlsOptions, tlsOptions);
    }

The rest of the config should take effect even if no tlsOptions are specified, but it doesn't.

Using 1.0.14

Seems it was changed to be like this in 1.0.11

@theturtle32 theturtle32 added this to the v1.0.15 milestone Jan 9, 2015
@theturtle32 theturtle32 self-assigned this Jan 9, 2015
theturtle32 added a commit that referenced this issue Jan 13, 2015
even when there is no tlsOptions specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants