Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3CWebSocket#close() lacks code/reason arguments #184

Closed
ibc opened this issue Feb 14, 2015 · 2 comments
Closed

W3CWebSocket#close() lacks code/reason arguments #184

ibc opened this issue Feb 14, 2015 · 2 comments

Comments

@ibc
Copy link
Collaborator

ibc commented Feb 14, 2015

When I implemented the W3CWebSocket shim I used this version of the WebSocket API in which close() does not accept arguments.

However in the current candidate it accepts "code" and "reason":

http://www.w3.org/TR/websockets/#the-websocket-interface

May be they should be added to the close() method?

@theturtle32
Copy link
Owner

That sounds reasonable, I don't expect it would hurt anything to update to the current draft API. It wouldn't affect backward compatibility.

@braytak
Copy link

braytak commented Feb 18, 2015

Reasonable!

However if the cited document is referenced as part of the change, this quote from the document itself should be taken into consideration...

It is inappropriate to cite this document as other than work in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants