Fix memory leak with multiple WebSocket servers on the same HTTP server #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case involves several WebSocket servers on the same HTTP server that each care about specific path in URL (for instance, one handles
ws://localhost/ws1
and anotherws://localhost/ws2
).In this scenario I do not want to reject request if it doesn't correspond to particular WebSocketServer's path. However, if I do not accept and do not reject request, it will be kept in memory even after original socket connection is closed entirely.
One workaround is to use
wsServer.handleRequestResolved(request);
, which is not a public API and not intuitive.I decided that at least when socket is closed, request should be removed from memory.
BTW, I'd also like to see
request.ignore()
method that allows to clean memory earlier (without explicitly accepting or rejecting the whole connection), but in either case, this PR is a last defense from memory leaks in mentioned and similar scenarios.